You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/11/10 06:30:19 UTC

[kudu-CR](branch-1.10.x) [thirdparty] add license info about yaml-cpp 

Hello Kudu Jenkins,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/14681

to review the following change.


Change subject: [thirdparty] add license info about yaml-cpp
......................................................................

[thirdparty] add license info about yaml-cpp

Added license information on yaml-cpp (build/test-only dependency)
into thirdparty/LICENSE.txt.

This patch doesn't have any functional modifications.

Change-Id: I65dfaa917fdf4f0831471b3e730bf8be19ebdc2d
Reviewed-on: http://gerrit.cloudera.org:8080/14637
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 9e6e729dfa9ab8613c4f0daf78c4b4a7feeef38c)
  Conflicts:
      thirdparty/LICENSE.txt
  modified:
      thirdparty/LICENSE.txt
      commit description
          Removed chrony-related part from the cherry-picked changelist
---
M thirdparty/LICENSE.txt
1 file changed, 25 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/14681/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14681
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I65dfaa917fdf4f0831471b3e730bf8be19ebdc2d
Gerrit-Change-Number: 14681
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.10.x) [thirdparty] add license info about yaml-cpp

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14681 )

Change subject: [thirdparty] add license info about yaml-cpp
......................................................................

[thirdparty] add license info about yaml-cpp

Added license information on yaml-cpp (build/test-only dependency)
into thirdparty/LICENSE.txt.

This patch doesn't have any functional modifications.

Change-Id: I65dfaa917fdf4f0831471b3e730bf8be19ebdc2d
Reviewed-on: http://gerrit.cloudera.org:8080/14637
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 9e6e729dfa9ab8613c4f0daf78c4b4a7feeef38c)
  Conflicts:
      thirdparty/LICENSE.txt
  modified:
      thirdparty/LICENSE.txt
      commit description
          Removed chrony-related part from the cherry-picked changelist
Reviewed-on: http://gerrit.cloudera.org:8080/14681
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M thirdparty/LICENSE.txt
1 file changed, 25 insertions(+), 0 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14681
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I65dfaa917fdf4f0831471b3e730bf8be19ebdc2d
Gerrit-Change-Number: 14681
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.10.x) [thirdparty] add license info about yaml-cpp

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14681 )

Change subject: [thirdparty] add license info about yaml-cpp
......................................................................


Patch Set 1: Verified+1 Code-Review+2

Text-file only change: thirdparty/LICENSE.txt


-- 
To view, visit http://gerrit.cloudera.org:8080/14681
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I65dfaa917fdf4f0831471b3e730bf8be19ebdc2d
Gerrit-Change-Number: 14681
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 10 Nov 2019 06:31:35 +0000
Gerrit-HasComments: No