You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jayzhan211 (via GitHub)" <gi...@apache.org> on 2024/03/18 07:54:55 UTC
[PR] Suppress self update for window [arrow-datafusion]
jayzhan211 opened a new pull request, #9661:
URL: https://github.com/apache/arrow-datafusion/pull/9661
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CI] Suppress self update for window [arrow-datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 commented on PR #9661:
URL: https://github.com/apache/arrow-datafusion/pull/9661#issuecomment-2003956013
I create a new label `CI/CD pipeline` mainly for fix that related to CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress self update for windows CI runner [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #9661:
URL: https://github.com/apache/arrow-datafusion/pull/9661#issuecomment-2005216441
Merging to stop CI failures on main -- let's contemplate adding the same for other OS's (@comphead 's comment https://influxdata.slack.com/archives/C04PASKL88P/p1710802371742879?thread_ts=1710795428.769569&cid=C04PASKL88P) as a follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress self update for windows CI runner [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #9661:
URL: https://github.com/apache/arrow-datafusion/pull/9661#discussion_r1528968488
##########
.github/actions/setup-windows-builder/action.yaml:
##########
@@ -38,8 +38,7 @@ runs:
- name: Setup Rust toolchain
shell: bash
run: |
- rustup update stable
- rustup toolchain install stable
+ rustup toolchain install stable --no-self-update
Review Comment:
I think it helps to give some context about the rationale for certain changes (so
they are less likely to get lost in refactors):
```suggestion
# Avoid self update to avoid CI failures: https://github.com/apache/arrow-datafusion/issues/9653
rustup toolchain install stable --no-self-update
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress self update for windows CI runner [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #9661:
URL: https://github.com/apache/arrow-datafusion/pull/9661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress self update for window [arrow-datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 commented on PR #9661:
URL: https://github.com/apache/arrow-datafusion/pull/9661#issuecomment-2003988220
ci: critial, ci: important and ci: feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress self update for windows CI runner [arrow-datafusion]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #9661:
URL: https://github.com/apache/arrow-datafusion/pull/9661#discussion_r1529105327
##########
.github/actions/setup-windows-builder/action.yaml:
##########
@@ -38,8 +38,8 @@ runs:
- name: Setup Rust toolchain
shell: bash
run: |
- rustup update stable
- rustup toolchain install stable
+ # Avoid self update to avoid CI failures: https://github.com/apache/arrow-datafusion/issues/9653
Review Comment:
should we add the same for other OS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress self update for windows CI runner [arrow-datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 commented on code in PR #9661:
URL: https://github.com/apache/arrow-datafusion/pull/9661#discussion_r1529469895
##########
.github/actions/setup-windows-builder/action.yaml:
##########
@@ -38,8 +38,8 @@ runs:
- name: Setup Rust toolchain
shell: bash
run: |
- rustup update stable
- rustup toolchain install stable
+ # Avoid self update to avoid CI failures: https://github.com/apache/arrow-datafusion/issues/9653
Review Comment:
@comphead I think we don't need to disable self update for other OS, the issue is window only. After the issue is solved, we can enable self update again.
@alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org