You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/06 09:08:00 UTC

[GitHub] [flink] dianfu commented on pull request #12824: [FLINK-18488][python] Added additional params to CsvTableSource constructor

dianfu commented on pull request #12824:
URL: https://github.com/apache/flink/pull/12824#issuecomment-654112165


   > @BryceCicada Good catch! Thanks a lot for the contribution. Just left a few minor comments. Should we also support emptyColumnAsNull? Besides, there are checkstyle issues which should be addressed.
   
   @BryceCicada Thanks for the update. There are check style issues in the first commit which failed the tests. It seems that it's not addressed in the latest PR. I guess you missed this comment. :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org