[jira] [Commented] (FLINK-29794) Flink Operator Need to Include Cause for Exceptions If Possible

["Gyula Fora (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-29794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625913#comment-17625913 ] 

Gyula Fora commented on FLINK-29794:
------------------------------------

I agree with the suggestion, but I think this is general good practice and if the pattern wasn’t used its an honest developer/reviewer mistake.

probably not intentional in most cases:)

> Flink Operator Need to Include Cause for Exceptions If Possible
> ---------------------------------------------------------------
>
>                 Key: FLINK-29794
>                 URL: https://issues.apache.org/jira/browse/FLINK-29794
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kubernetes Operator
>    Affects Versions: kubernetes-operator-1.3.0
>            Reporter: Zhou Jiang
>            Priority: Major
>
> For easier debugging and consistent stack trace, it would be appreciated if Exceptions are always thrown with cause (if exists), instead of persisting string message & silently swallow the cause. 
> This issue currently present in apache.flink.kubernetes.operator.reconciler.diff.ReflectiveDiffBuilder and apache.flink.kubernetes.operator.utils.EnvUtils
>  
> We would like to suggest this as a pattern for future exception handling as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)