You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@btopenworld.com> on 2003/12/06 22:55:01 UTC
PATCH: Convert text appropriately for console output and input
Does this look right?
- Julian
Re: PATCH: Convert text appropriately for console output and input
Posted by Julian Foad <ju...@btopenworld.com>.
(The subject line shouldn't have said "and input".)
Julian Foad wrote:
> Does this look right?
[...]
> Format and convert text appropriately for console output.
[...]
> * subversion/clients/cmdline/notify.c
> (notify): Quote paths where they appear within a sentence.
This bit requires the quotes to be expected by the tests, otherwise schedule-tests.py and merge-tests.py fail. An addition to the patch is attached.
- Julian
Re: PATCH: Convert text appropriately for console output and input
Posted by Julian Foad <ju...@btopenworld.com>.
Branko Čibej wrote:
> Julian Foad wrote:
>
>>Does this look right?
>
> Yes, but...
Thanks. Committed in r7960 ...
>>-/* ### todo: This function doesn't really belong in this header, but
>>- it didn't seem worthwhile to create a new header just for one
>>- function, especially since this should probably move to APR as
>>- apr_cmdline_init() or whatever anyway. There's nothing
>>- svn-specific in its code, other than SVN_WIN32, which obviously APR
>>- has its own way of dealing with. Thoughts? (Brane?) */
>>-/* ### Well, it's not one function any more, so it now has its own
>>- header. Besides, everything here is svn-specific. --brane */
>>+/* ### todo: This function should perhaps move to APR as
>>+ apr_cmdline_init() or whatever. */
>
> ...this bit does not. The point of my reply to Karl's comment was that
> this initializatino does _not_ belong in APR.
... without that comment.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: PATCH: Convert text appropriately for console output and input
Posted by Branko Čibej <br...@xbc.nu>.
Julian Foad wrote:
> Branko Čibej wrote:
>
>> Julian Foad wrote:
>>
>>> Does this look right?
>>
>>
>> Yes, but...
>>
>>> -/* ### todo: This function doesn't really belong in this header, but
>>> - it didn't seem worthwhile to create a new header just for one
>>> - function, especially since this should probably move to APR as
>>> - apr_cmdline_init() or whatever anyway. There's nothing
>>> - svn-specific in its code, other than SVN_WIN32, which obviously APR
>>> - has its own way of dealing with. Thoughts? (Brane?) */
>>> -/* ### Well, it's not one function any more, so it now has its own
>>> - header. Besides, everything here is svn-specific. --brane */
>>> +/* ### todo: This function should perhaps move to APR as
>>> + apr_cmdline_init() or whatever. */
>>
>>
>> ...this bit does not. The point of my reply to Karl's comment was that
>> this initializatino does _not_ belong in APR.
>
>
> Oh - thanks for picking me up on that. In that case it doesn't look
> like an issue that needs to be marked for future attention, so may I
> just delete that pair of comments entirely?
I don't mind if you do. I left the comments in for historical reasons,
but since we're a version control system, history can take care of
itself. :-)
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: PATCH: Convert text appropriately for console output and input
Posted by Julian Foad <ju...@btopenworld.com>.
Branko Čibej wrote:
> Julian Foad wrote:
>
>>Does this look right?
>
> Yes, but...
>
>>-/* ### todo: This function doesn't really belong in this header, but
>>- it didn't seem worthwhile to create a new header just for one
>>- function, especially since this should probably move to APR as
>>- apr_cmdline_init() or whatever anyway. There's nothing
>>- svn-specific in its code, other than SVN_WIN32, which obviously APR
>>- has its own way of dealing with. Thoughts? (Brane?) */
>>-/* ### Well, it's not one function any more, so it now has its own
>>- header. Besides, everything here is svn-specific. --brane */
>>+/* ### todo: This function should perhaps move to APR as
>>+ apr_cmdline_init() or whatever. */
>
> ...this bit does not. The point of my reply to Karl's comment was that
> this initializatino does _not_ belong in APR.
Oh - thanks for picking me up on that. In that case it doesn't look like an issue that needs to be marked for future attention, so may I just delete that pair of comments entirely?
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: PATCH: Convert text appropriately for console output and input
Posted by Branko Čibej <br...@xbc.nu>.
Julian Foad wrote:
> Does this look right?
Yes, but...
>
>-/* ### todo: This function doesn't really belong in this header, but
>- it didn't seem worthwhile to create a new header just for one
>- function, especially since this should probably move to APR as
>- apr_cmdline_init() or whatever anyway. There's nothing
>- svn-specific in its code, other than SVN_WIN32, which obviously APR
>- has its own way of dealing with. Thoughts? (Brane?) */
>-/* ### Well, it's not one function any more, so it now has its own
>- header. Besides, everything here is svn-specific. --brane */
>+/* ### todo: This function should perhaps move to APR as
>+ apr_cmdline_init() or whatever. */
>
>
...this bit does not. The point of my reply to Karl's comment was that
this initializatino does _not_ belong in APR.
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: PATCH: Convert text appropriately for console output and input
Posted by Erik Huelsmann <e....@gmx.net>.
> Does this look right?
It does to me. Except for one little thing:
> case svn_wc_notify_failed_revert:
>- printf ("Failed to revert %s -- try updating instead.\n",
path_stdout);
>+ printf ("Failed to revert '%s' -- try updating instead.\n",
path_stdout);
> break;
I've been trying to replace all '--' with '; ' for consistency (and removing
trailing '.'-s on error messages) like this:
+ printf ("Failed to revert '%s'; try updating instead\n",
path_stdout);
If you're looking for something to do: it seems there are a *lot* of
locations where we would need to call svn_path_local_style where we currently are
not. Your code made clear to me that there are cases in which we do, but in the
libs I haven't seen any calls to that function.
bye,
Erik.
--
+++ GMX - die erste Adresse für Mail, Message, More +++
Neu: Preissenkung für MMS und FreeMMS! http://www.gmx.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org