You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by GitBox <gi...@apache.org> on 2022/11/04 13:46:58 UTC

[GitHub] [incubator-sedona] tanelk opened a new pull request, #708: [SEDONA-189] Prepare geometries in broadcast join

tanelk opened a new pull request, #708:
URL: https://github.com/apache/incubator-sedona/pull/708

   
   ## Did you read the Contributor Guide?
   
   - Yes, I have read [Contributor Rules](https://sedona.apache.org/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/community/develop/)
   
   ## Is this PR related to a JIRA ticket?
   
   - Yes, the URL of the assoicated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-XXX. The PR name follows the format `[SEDONA-XXX] my subject`.
   
   ## What changes were proposed in this PR?
   Use prepared geometries in `BroadcastIndexJoinExec` to speed up queries. 
   
   ## How was this patch tested?
   Running the existing UTs in sql submodule
   
   ## Did this PR include necessary documentation updates?
   - No, this PR does not affect any public API so no need to change the docs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] umartin commented on pull request #708: [SEDONA-189] Prepare geometries in broadcast join

Posted by GitBox <gi...@apache.org>.
umartin commented on PR #708:
URL: https://github.com/apache/incubator-sedona/pull/708#issuecomment-1304437787

   > > @umartin Hi Martin, is this PreparedGeometry related to your https://issues.apache.org/jira/browse/SEDONA-178 ?
   > 
   > That seems like an unrelated issue.
   > 
   > `PreparedGeometry` is a tool in JTS that can speed up spatial predicates (contains, crosses, etc..). It does not directly impact distance queries and does not change impact correctness - performance only.
   
   I agree. It only impacts performance. I was just going off on a tangent when discussing refactoring spatial partitioning code. That might have caused some confusion 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] jiayuasu commented on pull request #708: [SEDONA-189] Prepare geometries in broadcast join

Posted by GitBox <gi...@apache.org>.
jiayuasu commented on PR #708:
URL: https://github.com/apache/incubator-sedona/pull/708#issuecomment-1304402415

   @umartin Hi Martin, is this PreparedGeometry related to your https://issues.apache.org/jira/browse/SEDONA-178 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] tanelk commented on pull request #708: [SEDONA-189] Prepare geometries in broadcast join

Posted by GitBox <gi...@apache.org>.
tanelk commented on PR #708:
URL: https://github.com/apache/incubator-sedona/pull/708#issuecomment-1304437059

   > @umartin Hi Martin, is this PreparedGeometry related to your https://issues.apache.org/jira/browse/SEDONA-178 ?
   
   That seems like an unrelated issue.
   
   `PreparedGeometry` is a tool in JTS that can speed up spatial predicates (contains, crosses, etc..). It does not directly impact distance queries and does not change impact correctness - performance only. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] jiayuasu merged pull request #708: [SEDONA-189] Prepare geometries in broadcast join

Posted by GitBox <gi...@apache.org>.
jiayuasu merged PR #708:
URL: https://github.com/apache/incubator-sedona/pull/708


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org