You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Shixiong Zhu (JIRA)" <ji...@apache.org> on 2016/04/05 19:52:25 UTC

[jira] [Resolved] (SPARK-14397) and tags are nested in LogPage

     [ https://issues.apache.org/jira/browse/SPARK-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shixiong Zhu resolved SPARK-14397.
----------------------------------
       Resolution: Fixed
         Assignee: Kousuke Saruta
    Fix Version/s: 2.0.0

> <html> and <body> tags are nested in LogPage
> --------------------------------------------
>
>                 Key: SPARK-14397
>                 URL: https://issues.apache.org/jira/browse/SPARK-14397
>             Project: Spark
>          Issue Type: Bug
>          Components: Web UI
>    Affects Versions: 2.0.0
>            Reporter: Kousuke Saruta
>            Assignee: Kousuke Saruta
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> In `LogPage`, the content to be rendered is defined as follows.
> {code}
>     val content =
>       <html>
>         <body>
>           {linkToMaster}
>           <div>
>             <div style="float:left; margin-right:10px">{backButton}</div>
>             <div style="float:left;">{range}</div>
>             <div style="float:right; margin-left:10px">{nextButton}</div>
>           </div>
>           <br />
>           <div style="height:500px; overflow:auto; padding:5px;">
>             <pre>{logText}</pre>
>           </div>
>         </body>
>       </html>
>     UIUtils.basicSparkPage(content, logType + " log page for " + pageName)
> {code}
> As you can see, <html> and <body> tags will be rendered.
> On the other hand, `UIUtils.basicSparkPage` will render those tags so those tags will be nested.
> {code}
>   def basicSparkPage(
>       content: => Seq[Node],
>       title: String,
>       useDataTables: Boolean = false): Seq[Node] = {
>     <html>
>       <head>
>         {commonHeaderNodes}
>         {if (useDataTables) dataTablesHeaderNodes else Seq.empty}
>         <title>{title}</title>
>       </head>
>       <body>
>         <div class="container-fluid">
>           <div class="row-fluid">
>             <div class="span12">
>               <h3 style="vertical-align: middle; display: inline-block;">
>                 <a style="text-decoration: none" href={prependBaseUri("/")}>
>                   <img src={prependBaseUri("/static/spark-logo-77x50px-hd.png")} />
>                   <span class="version"
>                         style="margin-right: 15px;">{org.apache.spark.SPARK_VERSION}</span>
>                 </a>
>                 {title}
>               </h3>
>             </div>
>           </div>
>           {content}
>         </div>
>       </body>
>     </html>
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org