You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2021/12/12 06:54:42 UTC

[GitHub] [buildstream] abderrahim commented on pull request #1448: Make public data immutable

abderrahim commented on pull request #1448:
URL: https://github.com/apache/buildstream/pull/1448#issuecomment-991844839


   How about instead of removing `set_public_data` from the public API, let's keep it with the new semantics (of only being allowed in configure phase). Looking at bst-plugins-experimental, all uses of `set_public_data()` don't need to be in `assemble()` and can be moved to either `configure()` or `configure_dependencies()`. The only exception (that generates public data based on the contents of the sandbox) is `dpkg_build`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org