[GitHub] [kafka] jlprat commented on a diff in pull request #13170: MINOR: Remove unused methods in CoreUtils

["jlprat (via GitHub)" <gi...@apache.org>]

jlprat commented on code in PR #13170:
URL: https://github.com/apache/kafka/pull/13170#discussion_r1190178039


##########
core/src/test/scala/unit/kafka/utils/CoreUtilsTest.scala:
##########
@@ -223,7 +204,7 @@ class CoreUtilsTest extends Logging {
     val map = new ConcurrentHashMap[Int, AtomicInteger]().asScala
     implicit val executionContext = ExecutionContext.fromExecutorService(Executors.newFixedThreadPool(nThreads))

Review Comment:
   As you are cleaning up some minor problems, feel free to type this `implicit val` as this is the recommended way:
   ```suggestion
       implicit val executionContext: ExecutionContext = ExecutionContext.fromExecutorService(Executors.newFixedThreadPool(nThreads))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org