[jira] [Commented] (OFBIZ-13719) Update to Apache Tika 4.1.0

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-13719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18130904#comment-18130904 ] 

ASF subversion and git services commented on OFBIZ-13719:
---------------------------------------------------------

Commit 8ad04e59bd55797ae67654f8323351ca376213e8 in ofbiz-framework's branch refs/heads/trunk from Mridul Pathak
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8ad04e59bd ]

Improved: Update Apache Tika to 4.1.0 (OFBIZ-13719)

Supersedes Dependabot PR #2400, which bumped the version only and did not compile against the Tika 4 API.

- Update tika to 4.1.0 and remove tika-parsers from the version catalog and the tika bundle; it is a pom-only aggregator in both Tika 3 and 4 and never added a jar to the classpath.
- Adapt SecuredUpload.recursiveParserWrapper to the Tika 4 API (TikaInputStream, RecursiveParserWrapperHandler without the embedded-resource limit argument, HttpHeaders.CONTENT_TYPE).
- Wrap the response stream in a TikaInputStream for PDFParser in WidgetMacroLibraryTests.


> Update to Apache Tika 4.1.0
> ---------------------------
>
>                 Key: OFBIZ-13719
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-13719
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework/security
>    Affects Versions: Upcoming Branch
>            Reporter: Mridul Pathak
>            Assignee: Mridul Pathak
>            Priority: Minor
>
> Dependabot PR #2400 bumps Apache Tika from 3.3.3 to 4.1.0, but trunk no longer compiles: Tika 4 changed {{Parser.parse}} to take a {{TikaInputStream}}, removed the {{RecursiveParserWrapperHandler(ContentHandlerFactory, int)}} constructor and the {{Metadata.CONTENT_TYPE}} constant. The failures are in the unused {{SecuredUpload.recursiveParserWrapper}} method and in {{WidgetMacroLibraryTests}}; the {{Tika}} facade's {{detect()}} methods used by the upload check are unchanged.
> h3. Proposed change
> * Update the {{tika}} version in {{gradle/libs.versions.toml}} to 4.1.0.
> * Drop {{tika-parsers}} from the catalog and the {{tika}} bundle: it is a pom-only aggregator in both 3.x and 4.x and puts no jar on the classpath.
> * Adapt {{SecuredUpload.recursiveParserWrapper}} and {{WidgetMacroLibraryTests}} to the 4.x API.
> Acceptance criteria: trunk builds and tests pass on Java 17, and the SecuredUpload upload check accepts and rejects the same files as with Tika 3.3.3.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)