You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2017/05/22 19:47:04 UTC
[jira] [Updated] (SOLR-10727) Optimize faceting on empty docSet to
return faster and not pollute filter cache
[ https://issues.apache.org/jira/browse/SOLR-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Smiley updated SOLR-10727:
--------------------------------
Attachment: SOLR_10727_SolrIndexSearcher_numDocs_0_docSet.patch
Trivial patch. Assuming tests pass, I'll commit tomorrow.
> Optimize faceting on empty docSet to return faster and not pollute filter cache
> -------------------------------------------------------------------------------
>
> Key: SOLR-10727
> URL: https://issues.apache.org/jira/browse/SOLR-10727
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: master (7.0)
>
> Attachments: SOLR_10727_SolrIndexSearcher_numDocs_0_docSet.patch
>
>
> In certain faceting circumstances (both classic SimpleFacets and JSON Facets), {{SolrIndexSearcher.numDocs(q,docSet)}} is invoked. numDocs can be improved to return early if the passed docSet (the base of documents to compute facets on) is empty. Since it doesn't today, it'll go create a filter cache entry (if it doesn't exist) for the query. Range faceting is a heavy user of this method since it'll be called for each range. If you're doing date range faceting and do time based sharding and have a time based filter query, then there's a decent chance the current index in question won't match the query. So lets not pollute the filter cache.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org