You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "belliottsmith (via GitHub)" <gi...@apache.org> on 2023/04/27 17:08:51 UTC
[GitHub] [cassandra] belliottsmith opened a new pull request, #2298: Bootstrap
belliottsmith opened a new pull request, #2298:
URL: https://github.com/apache/cassandra/pull/2298
Merge Accord Bootstrap (but do not integrate functionality)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] dcapwell commented on a diff in pull request #2298: Bootstrap
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #2298:
URL: https://github.com/apache/cassandra/pull/2298#discussion_r1187799946
##########
src/java/org/apache/cassandra/service/accord/serializers/ReadDataSerializers.java:
##########
@@ -81,7 +86,8 @@ public void serialize(ReadReply reply, DataOutputPlus out, int version) throws I
out.writeByte(0);
ReadOk readOk = (ReadOk) reply;
- TxnData.nullableSerializer.serialize((TxnData) readOk.data, out, version);
+ serializeNullable(readOk.unavailable, out, version, KeySerializers.ranges);
+ TxnData.serializer.serialize((TxnData) readOk.data, out, version);
Review Comment:
isn't this still nullable, such as write only transactions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] belliottsmith commented on pull request #2298: Bootstrap
Posted by "belliottsmith (via GitHub)" <gi...@apache.org>.
belliottsmith commented on PR #2298:
URL: https://github.com/apache/cassandra/pull/2298#issuecomment-1545408898
Could I get a +1 for this, so we can start working on a shared base? Just realised it hadn't been approved; have merged the corresponding accord PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] belliottsmith merged pull request #2298: Bootstrap
Posted by "belliottsmith (via GitHub)" <gi...@apache.org>.
belliottsmith merged PR #2298:
URL: https://github.com/apache/cassandra/pull/2298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org