You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/03/11 21:19:49 UTC

[GitHub] [calcite] julianhyde commented on a change in pull request #1099: [CALCITE-2908] Implement SQL LAST_DAY function

julianhyde commented on a change in pull request #1099: [CALCITE-2908] Implement SQL LAST_DAY function
URL: https://github.com/apache/calcite/pull/1099#discussion_r264435183
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
 ##########
 @@ -373,6 +374,8 @@ public Expression implement(RexToLixTranslator translator,
             BuiltInMethod.UNIX_TIMESTAMP_CEIL.method,
             BuiltInMethod.UNIX_DATE_CEIL.method), false);
 
+    defineMethod(LAST_DAY, "lastDay", NullPolicy.STRICT);
 
 Review comment:
   camelCase is fine. It just happens that there are no multi-word function names yet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services