You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/21 14:51:50 UTC
[GitHub] [beam] pavel-avilov opened a new pull request #15772: [BEAM-13032] [Playground] Implement the Log service
pavel-avilov opened a new pull request #15772:
URL: https://github.com/apache/beam/pull/15772
Implement the Log service uses Cloud logging.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
`ValidatesRunner` compliance status (on master branch)
--------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/badge/icon?subject=V1+Streaming">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon?subject=V1+Java+11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/badge/icon?subject=V2+Streaming">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon?subject=Java+8">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/icon?subject=Java+11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon?subject=Portable+Streaming">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/badge/icon?subject=Portable">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon?subject=Structured+Streaming">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Python</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon?subject=ValCont">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
</tbody>
</table>
Examples testing status on various runners
--------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/badge/icon?subject=V1+Java11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>Python</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
Post-Commit SDK/Transform Integration Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>Go</th>
<th>Java</th>
<th>Python</th>
</tr>
</thead>
<tbody>
<tr>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon?subject=3.6">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon?subject=3.7">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon?subject=3.8">
</a>
</td>
</tr>
</tbody>
</table>
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>---</th>
<th>Java</th>
<th>Python</th>
<th>Go</th>
<th>Website</th>
<th>Whitespace</th>
<th>Typescript</th>
</tr>
</thead>
<tbody>
<tr>
<td>Non-portable</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon?subject=Tests">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon?subject=Lint">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon?subject=Docker">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon?subject=Docs">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Portable</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pavel-avilov commented on pull request #15772: [BEAM-13032] [Playground] Implement the Log service
Posted by GitBox <gi...@apache.org>.
pavel-avilov commented on pull request #15772:
URL: https://github.com/apache/beam/pull/15772#issuecomment-948698432
R: @pabloem
R: @damondouglas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pavel-avilov commented on a change in pull request #15772: [BEAM-13032] [Playground] Implement the Log service
Posted by GitBox <gi...@apache.org>.
pavel-avilov commented on a change in pull request #15772:
URL: https://github.com/apache/beam/pull/15772#discussion_r735658557
##########
File path: playground/backend/internal/logger/handler.go
##########
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package logger
+
+type Handler interface {
Review comment:
Added, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pavel-avilov commented on a change in pull request #15772: [BEAM-13032] [Playground] Implement the Log service
Posted by GitBox <gi...@apache.org>.
pavel-avilov commented on a change in pull request #15772:
URL: https://github.com/apache/beam/pull/15772#discussion_r735658376
##########
File path: playground/backend/internal/logger/logger_test.go
##########
@@ -0,0 +1,326 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package logger
+
+import (
+ "fmt"
+ "testing"
+)
+
+var preparedHandler testHandler
+
+type testHandler struct {
+ array []string
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a change in pull request #15772: [BEAM-13032] [Playground] Implement the Log service
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #15772:
URL: https://github.com/apache/beam/pull/15772#discussion_r734096186
##########
File path: playground/backend/internal/logger/handler.go
##########
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package logger
+
+type Handler interface {
Review comment:
please add a brief summary of what a handle does for documentation? and a brief summary of what a logger does in the logger code?
##########
File path: playground/backend/internal/logger/logger_test.go
##########
@@ -0,0 +1,326 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package logger
+
+import (
+ "fmt"
+ "testing"
+)
+
+var preparedHandler testHandler
+
+type testHandler struct {
+ array []string
+}
+
+func (t *testHandler) Info(args ...interface{}) {
+ t.logMessage(INFO, args...)
+}
+
+func (t *testHandler) Infof(format string, args ...interface{}) {
+ t.logMessage(INFO, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) Warn(args ...interface{}) {
+ t.logMessage(WARN, args...)
+}
+
+func (t *testHandler) Warnf(format string, args ...interface{}) {
+ t.logMessage(WARN, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) Error(args ...interface{}) {
+ t.logMessage(ERROR, args...)
+}
+
+func (t *testHandler) Errorf(format string, args ...interface{}) {
+ t.logMessage(ERROR, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) Debug(args ...interface{}) {
+ t.logMessage(DEBUG, args...)
+}
+
+func (t *testHandler) Debugf(format string, args ...interface{}) {
+ t.logMessage(DEBUG, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) Fatal(args ...interface{}) {
+ t.logMessage(FATAL, args...)
+}
+
+func (t *testHandler) Fatalf(format string, args ...interface{}) {
+ t.logMessage(FATAL, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) logMessage(severity Severity, args ...interface{}) {
+ args = append([]interface{}{severity}, args...)
+ t.array = append(t.array, fmt.Sprint(args...))
+}
+
+func TestMain(m *testing.M) {
+ preparedHandler = testHandler{array: []string{}}
+ handlersTest := []Handler{&preparedHandler}
+ SetHandlers(handlersTest)
+ m.Run()
+}
+
+func TestInfo(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ var tests = []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Info",
+ args: args{args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Info(tt.args.args...)
+ value := append([]interface{}{INFO}, tt.args.args...)
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestInfof(t *testing.T) {
+ type args struct {
+ format string
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Infof",
+ args: args{
+ format: "TEST FORMAT %s",
+ args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Infof(tt.args.format, tt.args.args...)
+ value := append([]interface{}{INFO}, fmt.Sprintf(tt.args.format, tt.args.args...))
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestWarn(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Warn",
+ args: args{args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Warn(tt.args.args...)
+ value := append([]interface{}{WARN}, tt.args.args...)
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestWarnf(t *testing.T) {
+ type args struct {
+ format string
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Warnf",
+ args: args{
+ format: "TEST FORMAT %s",
+ args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Warnf(tt.args.format, tt.args.args...)
+ value := append([]interface{}{WARN}, fmt.Sprintf(tt.args.format, tt.args.args...))
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ fmt.Println(expectedValue)
+ fmt.Println(fmt.Sprint(value...))
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestError(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Error",
+ args: args{args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Error(tt.args.args...)
+ value := append([]interface{}{ERROR}, tt.args.args...)
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestErrorf(t *testing.T) {
+ type args struct {
+ format string
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Errorf",
+ args: args{
+ format: "TEST FORMAT %s",
+ args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Errorf(tt.args.format, tt.args.args...)
+ value := append([]interface{}{ERROR}, fmt.Sprintf(tt.args.format, tt.args.args...))
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestDebug(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Debug",
+ args: args{args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Debug(tt.args.args...)
+ value := append([]interface{}{DEBUG}, tt.args.args...)
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestDebugf(t *testing.T) {
+ type args struct {
+ format string
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Debugf",
+ args: args{
+ format: "TEST FORMAT %s",
+ args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Debugf(tt.args.format, tt.args.args...)
+ value := append([]interface{}{DEBUG}, fmt.Sprintf(tt.args.format, tt.args.args...))
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestFatal(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ // TODO: Add test cases.
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ })
+ }
+}
+
+func TestFatalf(t *testing.T) {
+ type args struct {
+ format string
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ // TODO: Add test cases.
Review comment:
please add test cases
##########
File path: playground/backend/internal/logger/logger_test.go
##########
@@ -0,0 +1,326 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package logger
+
+import (
+ "fmt"
+ "testing"
+)
+
+var preparedHandler testHandler
+
+type testHandler struct {
+ array []string
Review comment:
```suggestion
logs []string
```
Maybe rename this variable to `logs` or something more expressive of what it does?
##########
File path: playground/backend/internal/logger/logger_test.go
##########
@@ -0,0 +1,326 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package logger
+
+import (
+ "fmt"
+ "testing"
+)
+
+var preparedHandler testHandler
+
+type testHandler struct {
+ array []string
+}
+
+func (t *testHandler) Info(args ...interface{}) {
+ t.logMessage(INFO, args...)
+}
+
+func (t *testHandler) Infof(format string, args ...interface{}) {
+ t.logMessage(INFO, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) Warn(args ...interface{}) {
+ t.logMessage(WARN, args...)
+}
+
+func (t *testHandler) Warnf(format string, args ...interface{}) {
+ t.logMessage(WARN, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) Error(args ...interface{}) {
+ t.logMessage(ERROR, args...)
+}
+
+func (t *testHandler) Errorf(format string, args ...interface{}) {
+ t.logMessage(ERROR, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) Debug(args ...interface{}) {
+ t.logMessage(DEBUG, args...)
+}
+
+func (t *testHandler) Debugf(format string, args ...interface{}) {
+ t.logMessage(DEBUG, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) Fatal(args ...interface{}) {
+ t.logMessage(FATAL, args...)
+}
+
+func (t *testHandler) Fatalf(format string, args ...interface{}) {
+ t.logMessage(FATAL, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) logMessage(severity Severity, args ...interface{}) {
+ args = append([]interface{}{severity}, args...)
+ t.array = append(t.array, fmt.Sprint(args...))
+}
+
+func TestMain(m *testing.M) {
+ preparedHandler = testHandler{array: []string{}}
+ handlersTest := []Handler{&preparedHandler}
+ SetHandlers(handlersTest)
+ m.Run()
+}
+
+func TestInfo(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ var tests = []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Info",
+ args: args{args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Info(tt.args.args...)
+ value := append([]interface{}{INFO}, tt.args.args...)
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestInfof(t *testing.T) {
+ type args struct {
+ format string
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Infof",
+ args: args{
+ format: "TEST FORMAT %s",
+ args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Infof(tt.args.format, tt.args.args...)
+ value := append([]interface{}{INFO}, fmt.Sprintf(tt.args.format, tt.args.args...))
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestWarn(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Warn",
+ args: args{args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Warn(tt.args.args...)
+ value := append([]interface{}{WARN}, tt.args.args...)
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestWarnf(t *testing.T) {
+ type args struct {
+ format string
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Warnf",
+ args: args{
+ format: "TEST FORMAT %s",
+ args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Warnf(tt.args.format, tt.args.args...)
+ value := append([]interface{}{WARN}, fmt.Sprintf(tt.args.format, tt.args.args...))
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ fmt.Println(expectedValue)
+ fmt.Println(fmt.Sprint(value...))
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestError(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Error",
+ args: args{args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Error(tt.args.args...)
+ value := append([]interface{}{ERROR}, tt.args.args...)
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestErrorf(t *testing.T) {
+ type args struct {
+ format string
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Errorf",
+ args: args{
+ format: "TEST FORMAT %s",
+ args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Errorf(tt.args.format, tt.args.args...)
+ value := append([]interface{}{ERROR}, fmt.Sprintf(tt.args.format, tt.args.args...))
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestDebug(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Debug",
+ args: args{args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Debug(tt.args.args...)
+ value := append([]interface{}{DEBUG}, tt.args.args...)
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestDebugf(t *testing.T) {
+ type args struct {
+ format string
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Debugf",
+ args: args{
+ format: "TEST FORMAT %s",
+ args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Debugf(tt.args.format, tt.args.args...)
+ value := append([]interface{}{DEBUG}, fmt.Sprintf(tt.args.format, tt.args.args...))
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestFatal(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ // TODO: Add test cases.
Review comment:
please add test cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pavel-avilov commented on a change in pull request #15772: [BEAM-13032] [Playground] Implement the Log service
Posted by GitBox <gi...@apache.org>.
pavel-avilov commented on a change in pull request #15772:
URL: https://github.com/apache/beam/pull/15772#discussion_r735657863
##########
File path: playground/backend/internal/logger/logger_test.go
##########
@@ -0,0 +1,326 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package logger
+
+import (
+ "fmt"
+ "testing"
+)
+
+var preparedHandler testHandler
+
+type testHandler struct {
+ array []string
+}
+
+func (t *testHandler) Info(args ...interface{}) {
+ t.logMessage(INFO, args...)
+}
+
+func (t *testHandler) Infof(format string, args ...interface{}) {
+ t.logMessage(INFO, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) Warn(args ...interface{}) {
+ t.logMessage(WARN, args...)
+}
+
+func (t *testHandler) Warnf(format string, args ...interface{}) {
+ t.logMessage(WARN, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) Error(args ...interface{}) {
+ t.logMessage(ERROR, args...)
+}
+
+func (t *testHandler) Errorf(format string, args ...interface{}) {
+ t.logMessage(ERROR, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) Debug(args ...interface{}) {
+ t.logMessage(DEBUG, args...)
+}
+
+func (t *testHandler) Debugf(format string, args ...interface{}) {
+ t.logMessage(DEBUG, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) Fatal(args ...interface{}) {
+ t.logMessage(FATAL, args...)
+}
+
+func (t *testHandler) Fatalf(format string, args ...interface{}) {
+ t.logMessage(FATAL, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) logMessage(severity Severity, args ...interface{}) {
+ args = append([]interface{}{severity}, args...)
+ t.array = append(t.array, fmt.Sprint(args...))
+}
+
+func TestMain(m *testing.M) {
+ preparedHandler = testHandler{array: []string{}}
+ handlersTest := []Handler{&preparedHandler}
+ SetHandlers(handlersTest)
+ m.Run()
+}
+
+func TestInfo(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ var tests = []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Info",
+ args: args{args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Info(tt.args.args...)
+ value := append([]interface{}{INFO}, tt.args.args...)
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestInfof(t *testing.T) {
+ type args struct {
+ format string
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Infof",
+ args: args{
+ format: "TEST FORMAT %s",
+ args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Infof(tt.args.format, tt.args.args...)
+ value := append([]interface{}{INFO}, fmt.Sprintf(tt.args.format, tt.args.args...))
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestWarn(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Warn",
+ args: args{args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Warn(tt.args.args...)
+ value := append([]interface{}{WARN}, tt.args.args...)
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestWarnf(t *testing.T) {
+ type args struct {
+ format string
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Warnf",
+ args: args{
+ format: "TEST FORMAT %s",
+ args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Warnf(tt.args.format, tt.args.args...)
+ value := append([]interface{}{WARN}, fmt.Sprintf(tt.args.format, tt.args.args...))
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ fmt.Println(expectedValue)
+ fmt.Println(fmt.Sprint(value...))
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestError(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Error",
+ args: args{args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Error(tt.args.args...)
+ value := append([]interface{}{ERROR}, tt.args.args...)
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestErrorf(t *testing.T) {
+ type args struct {
+ format string
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Errorf",
+ args: args{
+ format: "TEST FORMAT %s",
+ args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Errorf(tt.args.format, tt.args.args...)
+ value := append([]interface{}{ERROR}, fmt.Sprintf(tt.args.format, tt.args.args...))
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestDebug(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Debug",
+ args: args{args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Debug(tt.args.args...)
+ value := append([]interface{}{DEBUG}, tt.args.args...)
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestDebugf(t *testing.T) {
+ type args struct {
+ format string
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Debugf",
+ args: args{
+ format: "TEST FORMAT %s",
+ args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Debugf(tt.args.format, tt.args.args...)
+ value := append([]interface{}{DEBUG}, fmt.Sprintf(tt.args.format, tt.args.args...))
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestFatal(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ // TODO: Add test cases.
Review comment:
Added, thanks!
##########
File path: playground/backend/internal/logger/logger_test.go
##########
@@ -0,0 +1,326 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package logger
+
+import (
+ "fmt"
+ "testing"
+)
+
+var preparedHandler testHandler
+
+type testHandler struct {
+ array []string
+}
+
+func (t *testHandler) Info(args ...interface{}) {
+ t.logMessage(INFO, args...)
+}
+
+func (t *testHandler) Infof(format string, args ...interface{}) {
+ t.logMessage(INFO, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) Warn(args ...interface{}) {
+ t.logMessage(WARN, args...)
+}
+
+func (t *testHandler) Warnf(format string, args ...interface{}) {
+ t.logMessage(WARN, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) Error(args ...interface{}) {
+ t.logMessage(ERROR, args...)
+}
+
+func (t *testHandler) Errorf(format string, args ...interface{}) {
+ t.logMessage(ERROR, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) Debug(args ...interface{}) {
+ t.logMessage(DEBUG, args...)
+}
+
+func (t *testHandler) Debugf(format string, args ...interface{}) {
+ t.logMessage(DEBUG, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) Fatal(args ...interface{}) {
+ t.logMessage(FATAL, args...)
+}
+
+func (t *testHandler) Fatalf(format string, args ...interface{}) {
+ t.logMessage(FATAL, fmt.Sprintf(format, args...))
+}
+
+func (t *testHandler) logMessage(severity Severity, args ...interface{}) {
+ args = append([]interface{}{severity}, args...)
+ t.array = append(t.array, fmt.Sprint(args...))
+}
+
+func TestMain(m *testing.M) {
+ preparedHandler = testHandler{array: []string{}}
+ handlersTest := []Handler{&preparedHandler}
+ SetHandlers(handlersTest)
+ m.Run()
+}
+
+func TestInfo(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ var tests = []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Info",
+ args: args{args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Info(tt.args.args...)
+ value := append([]interface{}{INFO}, tt.args.args...)
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestInfof(t *testing.T) {
+ type args struct {
+ format string
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Infof",
+ args: args{
+ format: "TEST FORMAT %s",
+ args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Infof(tt.args.format, tt.args.args...)
+ value := append([]interface{}{INFO}, fmt.Sprintf(tt.args.format, tt.args.args...))
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestWarn(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Warn",
+ args: args{args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Warn(tt.args.args...)
+ value := append([]interface{}{WARN}, tt.args.args...)
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestWarnf(t *testing.T) {
+ type args struct {
+ format string
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Warnf",
+ args: args{
+ format: "TEST FORMAT %s",
+ args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Warnf(tt.args.format, tt.args.args...)
+ value := append([]interface{}{WARN}, fmt.Sprintf(tt.args.format, tt.args.args...))
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ fmt.Println(expectedValue)
+ fmt.Println(fmt.Sprint(value...))
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestError(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Error",
+ args: args{args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Error(tt.args.args...)
+ value := append([]interface{}{ERROR}, tt.args.args...)
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestErrorf(t *testing.T) {
+ type args struct {
+ format string
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Errorf",
+ args: args{
+ format: "TEST FORMAT %s",
+ args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Errorf(tt.args.format, tt.args.args...)
+ value := append([]interface{}{ERROR}, fmt.Sprintf(tt.args.format, tt.args.args...))
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestDebug(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Debug",
+ args: args{args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Debug(tt.args.args...)
+ value := append([]interface{}{DEBUG}, tt.args.args...)
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestDebugf(t *testing.T) {
+ type args struct {
+ format string
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ {
+ name: "Debugf",
+ args: args{
+ format: "TEST FORMAT %s",
+ args: []interface{}{"TEST_VALUE"}},
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ Debugf(tt.args.format, tt.args.args...)
+ value := append([]interface{}{DEBUG}, fmt.Sprintf(tt.args.format, tt.args.args...))
+ expectedValue := preparedHandler.array[len(preparedHandler.array)-1]
+ if expectedValue != fmt.Sprint(value...) {
+ t.Errorf("Value %v not added in the array", expectedValue)
+ }
+ })
+ }
+}
+
+func TestFatal(t *testing.T) {
+ type args struct {
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ // TODO: Add test cases.
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ })
+ }
+}
+
+func TestFatalf(t *testing.T) {
+ type args struct {
+ format string
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ }{
+ // TODO: Add test cases.
Review comment:
Added, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #15772: [BEAM-13032] [Playground] Implement the Log service
Posted by GitBox <gi...@apache.org>.
pabloem merged pull request #15772:
URL: https://github.com/apache/beam/pull/15772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #15772: [BEAM-13032] [Playground] Implement the Log service
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #15772:
URL: https://github.com/apache/beam/pull/15772#issuecomment-951065025
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org