You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "ZhangYao (Code Review)" <ge...@cloudera.org> on 2019/06/27 09:24:33 UTC
[kudu-CR] Extend benchmark for ColumnarRowBlockToPB.
ZhangYao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13749
Change subject: Extend benchmark for ColumnarRowBlockToPB.
......................................................................
Extend benchmark for ColumnarRowBlockToPB.
Extend the origin ColumnarRowBlockToPB benchmark in two aspects.
Both column scale and selected row count are configurable.
Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d
---
M src/kudu/common/wire_protocol-test.cc
1 file changed, 87 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/13749/1
--
To view, visit http://gerrit.cloudera.org:8080/13749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d
Gerrit-Change-Number: 13749
Gerrit-PatchSet: 1
Gerrit-Owner: ZhangYao <tr...@gmail.com>
[kudu-CR] Extend benchmark for ColumnarRowBlockToPB.
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13749
to look at the new patch set (#3).
Change subject: Extend benchmark for ColumnarRowBlockToPB.
......................................................................
Extend benchmark for ColumnarRowBlockToPB.
Extend the origin ColumnarRowBlockToPB benchmark in two aspects.
Both column scale and selected row count are configurable.
Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d
---
M src/kudu/common/wire_protocol-test.cc
1 file changed, 93 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/13749/3
--
To view, visit http://gerrit.cloudera.org:8080/13749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d
Gerrit-Change-Number: 13749
Gerrit-PatchSet: 3
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Extend benchmark for ColumnarRowBlockToPB.
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13749
to look at the new patch set (#2).
Change subject: Extend benchmark for ColumnarRowBlockToPB.
......................................................................
Extend benchmark for ColumnarRowBlockToPB.
Extend the origin ColumnarRowBlockToPB benchmark in two aspects.
Both column scale and selected row count are configurable.
Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d
---
M src/kudu/common/wire_protocol-test.cc
1 file changed, 89 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/13749/2
--
To view, visit http://gerrit.cloudera.org:8080/13749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d
Gerrit-Change-Number: 13749
Gerrit-PatchSet: 2
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Extend benchmark for ColumnarRowBlockToPB.
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13749 )
Change subject: Extend benchmark for ColumnarRowBlockToPB.
......................................................................
Patch Set 4:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc
File src/kudu/common/wire_protocol-test.cc:
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@426
PS2, Line 426: vector<double> select_rates = {1.0};
> It seems that if set column_counts = {3, 30, 300} and select_rates = {1.0,
Maybe this will be better if you make 'kNumTrials' not affect the rowblock size itself?
You could also change this to a value-parameterized test, so that it turns into 9 separate test cases, and then mark wire_protocol-test as sharded in CMakeLists.txt
http://gerrit.cloudera.org:8080/#/c/13749/4/src/kudu/common/wire_protocol-test.cc
File src/kudu/common/wire_protocol-test.cc:
http://gerrit.cloudera.org:8080/#/c/13749/4/src/kudu/common/wire_protocol-test.cc@93
PS4, Line 93: ResetBenchMarkSchema
nit: Benchmark, not BenchMark
http://gerrit.cloudera.org:8080/#/c/13749/4/src/kudu/common/wire_protocol-test.cc@151
PS4, Line 151: 10000 * kNumTrials
why does the RowBlock size change based on the number of trials? I think we should use a fixed size RowBlock, and probably small (our default value of --scanner_batch_size_rows is 128, which is actually smaller than I thought it would be...)
http://gerrit.cloudera.org:8080/#/c/13749/4/src/kudu/common/wire_protocol-test.cc@156
PS4, Line 156: LOG_TIMING(INFO, Substitute("Coverting to PB with column count $0 and row select rate $1 ",
typo: Converting
http://gerrit.cloudera.org:8080/#/c/13749/4/src/kudu/common/wire_protocol-test.cc@160
PS4, Line 160: faststring direct, indirect;
probably would be good to init these outside the loop and just clear them inside the loop, so you don't include allocation in the benchmark
--
To view, visit http://gerrit.cloudera.org:8080/13749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d
Gerrit-Change-Number: 13749
Gerrit-PatchSet: 4
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Tue, 09 Jul 2019 03:45:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] Extend benchmark for ColumnarRowBlockToPB.
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13749 )
Change subject: Extend benchmark for ColumnarRowBlockToPB.
......................................................................
Patch Set 5:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc
File src/kudu/common/wire_protocol-test.cc:
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@426
PS2, Line 426: // select_rates = {1.0, 0.8, 0.5, 0.2} for benchmark.
> Maybe this will be better if you make 'kNumTrials' not affect the rowblock
I will do it latter :)
http://gerrit.cloudera.org:8080/#/c/13749/4/src/kudu/common/wire_protocol-test.cc
File src/kudu/common/wire_protocol-test.cc:
http://gerrit.cloudera.org:8080/#/c/13749/4/src/kudu/common/wire_protocol-test.cc@93
PS4, Line 93: ResetBenchmarkSchema
> nit: Benchmark, not BenchMark
Done
http://gerrit.cloudera.org:8080/#/c/13749/4/src/kudu/common/wire_protocol-test.cc@151
PS4, Line 151: 10000, &arena);
> why does the RowBlock size change based on the number of trials? I think we
Actually I refer to the original code to implement this. I guess it would like larger rowblock when AllowSlowTests is true to make more adequate test.
http://gerrit.cloudera.org:8080/#/c/13749/4/src/kudu/common/wire_protocol-test.cc@156
PS4, Line 156: faststring direct, indirect;
> typo: Converting
My mistake.
http://gerrit.cloudera.org:8080/#/c/13749/4/src/kudu/common/wire_protocol-test.cc@160
PS4, Line 160: pb.Clear();
> probably would be good to init these outside the loop and just clear them i
Done
--
To view, visit http://gerrit.cloudera.org:8080/13749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d
Gerrit-Change-Number: 13749
Gerrit-PatchSet: 5
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Tue, 09 Jul 2019 04:12:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] Extend benchmark for ColumnarRowBlockToPB.
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13749 )
Change subject: Extend benchmark for ColumnarRowBlockToPB.
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d
Gerrit-Change-Number: 13749
Gerrit-PatchSet: 5
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Tue, 09 Jul 2019 04:11:39 +0000
Gerrit-HasComments: No
[kudu-CR] Extend benchmark for ColumnarRowBlockToPB.
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Yao Xu, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13749
to look at the new patch set (#5).
Change subject: Extend benchmark for ColumnarRowBlockToPB.
......................................................................
Extend benchmark for ColumnarRowBlockToPB.
Extend the origin ColumnarRowBlockToPB benchmark in two aspects.
Both column scale and selected row count are configurable.
Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d
---
M src/kudu/common/wire_protocol-test.cc
1 file changed, 90 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/13749/5
--
To view, visit http://gerrit.cloudera.org:8080/13749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d
Gerrit-Change-Number: 13749
Gerrit-PatchSet: 5
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] Extend benchmark for ColumnarRowBlockToPB.
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13749 )
Change subject: Extend benchmark for ColumnarRowBlockToPB.
......................................................................
Patch Set 2:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc
File src/kudu/common/wire_protocol-test.cc:
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@91
PS2, Line 91: void ResetBenchMarkSchema(int n) {
nit: use 'num_columns' instead of 'n' so it's more descriptive
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@98
PS2, Line 98: UINT32
nit: the UINT type is more or less deprecated, we only use signed ints in the actual client APIs
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@99
PS2, Line 99: }
I think it'd be more readable to just write the above 6 lines as :
column_schemas.emplace_back(Substitute("col$0", i), i % 2 ? STRING : INT32);
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@115
PS2, Line 115: *reinterpret_cast<Slice*>(row.mutable_cell_ptr(j)) = col;
nit: use memcpy here instead of *reinterpret_cast
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@117
PS2, Line 117: *reinterpret_cast<uint32_t*>(row.mutable_cell_ptr(j)) = i;
same
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@118
PS2, Line 118: }
else { LOG(FATAL); }
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@123
PS2, Line 123: Row
nit: Rows
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@137
PS2, Line 137: int next = rand.Uniform(block->nrows());
nit: this loop would run very long when rate approaches 1.
Instead of ensuring you select exactly N rows, why not just loop over the rows, and for each row, generate a random double between 0 and 1, and if it's less than rate, set the row to selected? You might get not exactly N, but should be close enough for the benchmark
Another option would be something like:
vector<int> indexes(block->nrows());
std::iota(indexes.begin(), indexes.end(), 0);
std::shuffle(indexes.begin(), indexes.end());
indexes.resize(select_count);
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@149
PS2, Line 149: RunBenchMark
nit: "RunBenchmark" (Benchmark is one word, so not camel case)
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@426
PS2, Line 426: // select_rates = {1.0, 0.8, 0.5, 0.2} for benchmark.
maybe set these values if AllowSlowTests is true?
--
To view, visit http://gerrit.cloudera.org:8080/13749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d
Gerrit-Change-Number: 13749
Gerrit-PatchSet: 2
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 28 Jun 2019 06:08:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] Extend benchmark for ColumnarRowBlockToPB.
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13749 )
Change subject: Extend benchmark for ColumnarRowBlockToPB.
......................................................................
Extend benchmark for ColumnarRowBlockToPB.
Extend the origin ColumnarRowBlockToPB benchmark in two aspects.
Both column scale and selected row count are configurable.
Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d
Reviewed-on: http://gerrit.cloudera.org:8080/13749
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/common/wire_protocol-test.cc
1 file changed, 90 insertions(+), 13 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d
Gerrit-Change-Number: 13749
Gerrit-PatchSet: 6
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] Extend benchmark for ColumnarRowBlockToPB.
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13749 )
Change subject: Extend benchmark for ColumnarRowBlockToPB.
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc
File src/kudu/common/wire_protocol-test.cc:
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@426
PS2, Line 426: vector<double> select_rates = {1.0};
> maybe set these values if AllowSlowTests is true?
It seems that if set column_counts = {3, 30, 300} and select_rates = {1.0, 0.8, 0.5, 0.2} when AllowSlowTests is true will exceed the unit test time limit :(
--
To view, visit http://gerrit.cloudera.org:8080/13749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d
Gerrit-Change-Number: 13749
Gerrit-PatchSet: 4
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Thu, 04 Jul 2019 15:43:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] Extend benchmark for ColumnarRowBlockToPB.
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Yao Xu, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13749
to look at the new patch set (#4).
Change subject: Extend benchmark for ColumnarRowBlockToPB.
......................................................................
Extend benchmark for ColumnarRowBlockToPB.
Extend the origin ColumnarRowBlockToPB benchmark in two aspects.
Both column scale and selected row count are configurable.
Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d
---
M src/kudu/common/wire_protocol-test.cc
1 file changed, 88 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/13749/4
--
To view, visit http://gerrit.cloudera.org:8080/13749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d
Gerrit-Change-Number: 13749
Gerrit-PatchSet: 4
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] Extend benchmark for ColumnarRowBlockToPB.
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13749 )
Change subject: Extend benchmark for ColumnarRowBlockToPB.
......................................................................
Patch Set 3:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc
File src/kudu/common/wire_protocol-test.cc:
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@91
PS2, Line 91: }
> nit: use 'num_columns' instead of 'n' so it's more descriptive
Done
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@98
PS2, Line 98:
> nit: the UINT type is more or less deprecated, we only use signed ints in t
Done
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@99
PS2, Line 99: benchmark_schema_.Reset(column_schemas, 1);
> I think it'd be more readable to just write the above 6 lines as :
Done
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@115
PS2, Line 115: memcpy(row.mutable_cell_ptr(j), &i, sizeof(int32_t));
> nit: use memcpy here instead of *reinterpret_cast
Done
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@117
PS2, Line 117: LOG(FATAL) << "Unexpected type.";
> same
Done
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@118
PS2, Line 118: }
> else { LOG(FATAL); }
Done
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@123
PS2, Line 123: Row
> nit: Rows
Done
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@137
PS2, Line 137: select_vector->SetAllFalse();
> nit: this loop would run very long when rate approaches 1.
Done
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@149
PS2, Line 149: na arena(102
> nit: "RunBenchmark" (Benchmark is one word, so not camel case)
My mistake :(
http://gerrit.cloudera.org:8080/#/c/13749/2/src/kudu/common/wire_protocol-test.cc@426
PS2, Line 426: column_counts = {3, 30, 300};
> maybe set these values if AllowSlowTests is true?
Done
--
To view, visit http://gerrit.cloudera.org:8080/13749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie29937c316be624151e6c51e54545c4f023e603d
Gerrit-Change-Number: 13749
Gerrit-PatchSet: 3
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Tue, 02 Jul 2019 11:33:38 +0000
Gerrit-HasComments: Yes