You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2020/04/01 05:05:37 UTC

Review Request 72296: Added missing await in a cgroups isolator test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72296/
-----------------------------------------------------------

Review request for mesos and Qian Zhang.


Repository: mesos


Description
-------

Added missing await in a cgroups isolator test.


Diffs
-----

  src/tests/containerizer/cgroups_isolator_tests.cpp f4425f0b5fdecdad36fbd993eb75854b6764888b 


Diff: https://reviews.apache.org/r/72296/diff/1/


Testing
-------

`make check` currently fails on our internal CI. Investigation is required.


Thanks,

Greg Mann


Re: Review Request 72296: Added missing await in a cgroups isolator test.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72296/#review220165
-----------------------------------------------------------



Patch looks great!

Reviews applied: [72296]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh

- Mesos Reviewbot


On April 1, 2020, 5:05 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72296/
> -----------------------------------------------------------
> 
> (Updated April 1, 2020, 5:05 a.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added missing await in a cgroups isolator test.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp f4425f0b5fdecdad36fbd993eb75854b6764888b 
> 
> 
> Diff: https://reviews.apache.org/r/72296/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` currently fails on our internal CI. Investigation is required.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>