You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/11/14 11:33:55 UTC
[GitHub] [dolphinscheduler] lenboo opened a new issue, #12896: [Improvement][Datasource]It is unnecessary to check the validity when saving the data source
lenboo opened a new issue, #12896:
URL: https://github.com/apache/dolphinscheduler/issues/12896
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
It is unnecessary to check the validity when saving the data source.
Eg:
The datasource is only open to the specified worker, but we cannot connect it from API-SERVER.
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng closed issue #12896: [Improvement][Datasource]It is unnecessary to check the validity when saving the data source
Posted by GitBox <gi...@apache.org>.
caishunfeng closed issue #12896: [Improvement][Datasource]It is unnecessary to check the validity when saving the data source
URL: https://github.com/apache/dolphinscheduler/issues/12896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #12896: [Improvement][Datasource]It is unnecessary to check the validity when saving the data source
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #12896:
URL: https://github.com/apache/dolphinscheduler/issues/12896#issuecomment-1318147707
> +1 i will improve it.
@DarkAssassinator I had merged the pr :smiling_face_with_tear:
@insist777 next time please leave the comment before submitting pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on issue #12896: [Improvement][Datasource]It is unnecessary to check the validity when saving the data source
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on issue #12896:
URL: https://github.com/apache/dolphinscheduler/issues/12896#issuecomment-1314696118
+1 i will improve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #12896: [Improvement][Datasource]It is unnecessary to check the validity when saving the data source
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #12896:
URL: https://github.com/apache/dolphinscheduler/issues/12896#issuecomment-1313541971
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on issue #12896: [Improvement][Datasource]It is unnecessary to check the validity when saving the data source
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on issue #12896:
URL: https://github.com/apache/dolphinscheduler/issues/12896#issuecomment-1318197596
> > +1 i will improve it.
>
> @DarkAssassinator I had merged the pr 🥲 @insist777 next time please leave the comment before submitting pr.
@caishunfeng , sure, welcome anyone to help fix issues.
@insist777 thx bro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org