You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/07 23:01:42 UTC
[GitHub] kaxil commented on a change in pull request #3714: [AIRFLOW-2867]
Refactor code to conform Python standards & guidelines
kaxil commented on a change in pull request #3714: [AIRFLOW-2867] Refactor code to conform Python standards & guidelines
URL: https://github.com/apache/incubator-airflow/pull/3714#discussion_r208411271
##########
File path: airflow/contrib/operators/oracle_to_azure_data_lake_transfer.py
##########
@@ -1,113 +1,115 @@
-# -*- coding: utf-8 -*-
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-from airflow.hooks.oracle_hook import OracleHook
-from airflow.contrib.hooks.azure_data_lake_hook import AzureDataLakeHook
-from airflow.models import BaseOperator
-from airflow.utils.decorators import apply_defaults
-from airflow.utils.file import TemporaryDirectory
-
-import unicodecsv as csv
-import os
-
-
-class OracleToAzureDataLakeTransfer(BaseOperator):
- """
- Moves data from Oracle to Azure Data Lake. The operator runs the query against
- Oracle and stores the file locally before loading it into Azure Data Lake.
-
-
- :param filename: file name to be used by the csv file.
- :type filename: str
- :param azure_data_lake_conn_id: destination azure data lake connection.
- :type azure_data_lake_conn_id: str
- :param azure_data_lake_path: destination path in azure data lake to put the file.
- :type azure_data_lake_path: str
- :param oracle_conn_id: source Oracle connection.
- :type oracle_conn_id: str
- :param sql: SQL query to execute against the Oracle database. (templated)
- :type sql: str
- :param sql_params: Parameters to use in sql query. (templated)
- :type sql_params: str
- :param delimiter: field delimiter in the file.
- :type delimiter: str
- :param encoding: enconding type for the file.
- :type encoding: str
- :param quotechar: Character to use in quoting.
- :type quotechar: str
- :param quoting: Quoting strategy. See unicodecsv quoting for more information.
- :type quoting: str
- """
-
- template_fields = ('filename', 'sql', 'sql_params')
- ui_color = '#e08c8c'
-
- @apply_defaults
- def __init__(
- self,
- filename,
- azure_data_lake_conn_id,
- azure_data_lake_path,
- oracle_conn_id,
- sql,
- sql_params={},
- delimiter=",",
- encoding="utf-8",
- quotechar='"',
- quoting=csv.QUOTE_MINIMAL,
- *args, **kwargs):
- super(OracleToAzureDataLakeTransfer, self).__init__(*args, **kwargs)
- self.filename = filename
- self.oracle_conn_id = oracle_conn_id
- self.sql = sql
- self.sql_params = sql_params
- self.azure_data_lake_conn_id = azure_data_lake_conn_id
- self.azure_data_lake_path = azure_data_lake_path
- self.delimiter = delimiter
- self.encoding = encoding
- self.quotechar = quotechar
- self.quoting = quoting
-
- def _write_temp_file(self, cursor, path_to_save):
- with open(path_to_save, 'wb') as csvfile:
- csv_writer = csv.writer(csvfile, delimiter=self.delimiter,
- encoding=self.encoding, quotechar=self.quotechar,
- quoting=self.quoting)
- csv_writer.writerow(map(lambda field: field[0], cursor.description))
- csv_writer.writerows(cursor)
- csvfile.flush()
-
- def execute(self, context):
- oracle_hook = OracleHook(oracle_conn_id=self.oracle_conn_id)
- azure_data_lake_hook = AzureDataLakeHook(
- azure_data_lake_conn_id=self.azure_data_lake_conn_id)
-
- self.log.info("Dumping Oracle query results to local file")
- conn = oracle_hook.get_conn()
- cursor = conn.cursor()
- cursor.execute(self.sql, self.sql_params)
-
- with TemporaryDirectory(prefix='airflow_oracle_to_azure_op_') as temp:
- self._write_temp_file(cursor, os.path.join(temp, self.filename))
- self.log.info("Uploading local file to Azure Data Lake")
- azure_data_lake_hook.upload_file(os.path.join(temp, self.filename),
- os.path.join(self.azure_data_lake_path,
- self.filename))
- cursor.close()
- conn.close()
+# -*- coding: utf-8 -*-
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.hooks.oracle_hook import OracleHook
+from airflow.contrib.hooks.azure_data_lake_hook import AzureDataLakeHook
+from airflow.models import BaseOperator
+from airflow.utils.decorators import apply_defaults
+from airflow.utils.file import TemporaryDirectory
+
+import unicodecsv as csv
+import os
+
+
+class OracleToAzureDataLakeTransfer(BaseOperator):
+ """
+ Moves data from Oracle to Azure Data Lake. The operator runs the query against
+ Oracle and stores the file locally before loading it into Azure Data Lake.
+
+
+ :param filename: file name to be used by the csv file.
+ :type filename: str
+ :param azure_data_lake_conn_id: destination azure data lake connection.
+ :type azure_data_lake_conn_id: str
+ :param azure_data_lake_path: destination path in azure data lake to put the file.
+ :type azure_data_lake_path: str
+ :param oracle_conn_id: source Oracle connection.
+ :type oracle_conn_id: str
+ :param sql: SQL query to execute against the Oracle database. (templated)
+ :type sql: str
+ :param sql_params: Parameters to use in sql query. (templated)
+ :type sql_params: str
+ :param delimiter: field delimiter in the file.
+ :type delimiter: str
+ :param encoding: enconding type for the file.
+ :type encoding: str
+ :param quotechar: Character to use in quoting.
+ :type quotechar: str
+ :param quoting: Quoting strategy. See unicodecsv quoting for more information.
+ :type quoting: str
+ """
+
+ template_fields = ('filename', 'sql', 'sql_params')
+ ui_color = '#e08c8c'
+
+ @apply_defaults
+ def __init__(
+ self,
+ filename,
+ azure_data_lake_conn_id,
+ azure_data_lake_path,
+ oracle_conn_id,
+ sql,
+ sql_params=None,
+ delimiter=",",
+ encoding="utf-8",
+ quotechar='"',
+ quoting=csv.QUOTE_MINIMAL,
+ *args, **kwargs):
+ super(OracleToAzureDataLakeTransfer, self).__init__(*args, **kwargs)
+ if sql_params is None:
Review comment:
@feng-tao This line is changed. Git shows entire file has changed due to termination of line. Check https://stackoverflow.com/questions/19593909/git-diff-sees-whole-file-as-changed-when-its-not for more info
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services