You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/14 11:03:54 UTC
[GitHub] [airflow] codenamestif opened a new pull request #15848: Add support of capacity provider strategy for ECSOperator
codenamestif opened a new pull request #15848:
URL: https://github.com/apache/airflow/pull/15848
This PR adds support of support of capacity provider strategy for ECSOperator. The logic is based on [ECS.Client.run_task documentation](https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ecs.html#ECS.Client.run_task).
Closes #8381
Note:
There is a logic related to the `platform_version` that I find tricky:
```
if self.launch_type == 'FARGATE':
run_opts['platformVersion'] = self.platform_version
```
As for me, the operator should pass every parameter that user provided to the `run_task`. And that should be responsibility of the user to think about which parameters and under which conditions are needed. But to be consistent with the logic, I also provide `platform_version` if `capacity_provider_strategy` is specified. `capacity_provider_strategy` can be used only with Fargate, so the platform version should be passed as well. But as we can see, picking the parameters introduces the complexity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #15848: Add support of capacity provider strategy for ECSOperator
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #15848:
URL: https://github.com/apache/airflow/pull/15848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] codenamestif commented on pull request #15848: Add support of capacity provider strategy for ECSOperator
Posted by GitBox <gi...@apache.org>.
codenamestif commented on pull request #15848:
URL: https://github.com/apache/airflow/pull/15848#issuecomment-857155792
@feluelle could you please have a look if anything else needs to be done? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15848: Add support of capacity provider strategy for ECSOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15848:
URL: https://github.com/apache/airflow/pull/15848#issuecomment-860109136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15848: Add support of capacity provider strategy for ECSOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15848:
URL: https://github.com/apache/airflow/pull/15848#issuecomment-841224194
[The Workflow run](https://github.com/apache/airflow/actions/runs/839587614) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] codenamestif commented on pull request #15848: Add support of capacity provider strategy for ECSOperator
Posted by GitBox <gi...@apache.org>.
codenamestif commented on pull request #15848:
URL: https://github.com/apache/airflow/pull/15848#issuecomment-860118967
@potiuk done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15848: Add support of capacity provider strategy for ECSOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15848:
URL: https://github.com/apache/airflow/pull/15848#issuecomment-860127555
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org