You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "singhpk234 (via GitHub)" <gi...@apache.org> on 2023/03/22 01:08:15 UTC
[GitHub] [iceberg] singhpk234 opened a new pull request, #7164: Python: Update docker file
singhpk234 opened a new pull request, #7164:
URL: https://github.com/apache/iceberg/pull/7164
This change focuses mainly to make sure docker file uses the most recent set-up as per 1.2.0 release
[1] AWS SDK changed to 2.20.18
[2] url-connection-client is no longer required
[3] minor refactoring
Also updates iceberg_bug_report yml with recent version.
cc @jackye1995 @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] singhpk234 commented on pull request #7164: Python: Update docker file
Posted by "singhpk234 (via GitHub)" <gi...@apache.org>.
singhpk234 commented on PR #7164:
URL: https://github.com/apache/iceberg/pull/7164#issuecomment-1480335171
mostly picked the docker changes from [tabular-spark image](https://github.com/tabular-io/docker-spark-iceberg/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a diff in pull request #7164: Python: Update docker file
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on code in PR #7164:
URL: https://github.com/apache/iceberg/pull/7164#discussion_r1145466240
##########
python/mkdocs/docs/verify-release.md:
##########
@@ -101,6 +101,6 @@ This will include a Minio S3 container being spun up.
Votes are cast by replying to the release candidate announcement email on the dev mailing list with either `+1`, `0`, or `-1`.
Review Comment:
can we add a "for example" in the end? So we don't really have to update the line below with the latest version anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #7164: Python: Update docker file
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #7164:
URL: https://github.com/apache/iceberg/pull/7164#discussion_r1144181704
##########
python/dev/Dockerfile:
##########
@@ -37,22 +37,20 @@ RUN mkdir -p ${HADOOP_HOME} && mkdir -p ${SPARK_HOME} && mkdir -p /home/iceberg/
WORKDIR ${SPARK_HOME}
ENV SPARK_VERSION=3.3.2
+ENV ICEBERG_VERSION=1.2.0
+ENV AWS_SDK_VERSION=2.20.18
Review Comment:
Nice, thanks for cleaning this up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a diff in pull request #7164: Python: Update docker file
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on code in PR #7164:
URL: https://github.com/apache/iceberg/pull/7164#discussion_r1145307160
##########
python/mkdocs/docs/verify-release.md:
##########
@@ -101,6 +101,6 @@ This will include a Minio S3 container being spun up.
Votes are cast by replying to the release candidate announcement email on the dev mailing list with either `+1`, `0`, or `-1`.
-> \[ \] +1 Release this as Apache Iceberg 1.1.0 \[ \] +0 \[ \] -1 Do not release this because…
+> \[ \] +1 Release this as Apache Iceberg 1.2.0 \[ \] +0 \[ \] -1 Do not release this because…
Review Comment:
looks like this sentence itself is not right, since it should be `pyiceberg x.x.x`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #7164: Python: Update docker file
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on PR #7164:
URL: https://github.com/apache/iceberg/pull/7164#issuecomment-1480342128
Thanks @singhpk234 for the contribution! And thanks for the review @Fokko and @amogh-jahagirdar !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #7164: Python: Update docker file
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 merged PR #7164:
URL: https://github.com/apache/iceberg/pull/7164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #7164: Python: Update docker file
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #7164:
URL: https://github.com/apache/iceberg/pull/7164#discussion_r1145275080
##########
.github/ISSUE_TEMPLATE/iceberg_bug_report.yml:
##########
@@ -9,7 +9,8 @@ body:
description: What Apache Iceberg version are you using?
multiple: false
options:
- - "1.1.0 (latest release)"
Review Comment:
Maybe we should make this part of the `How to release` process? https://iceberg.apache.org/how-to-release/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a diff in pull request #7164: Python: Update docker file
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on code in PR #7164:
URL: https://github.com/apache/iceberg/pull/7164#discussion_r1145287961
##########
.github/ISSUE_TEMPLATE/iceberg_bug_report.yml:
##########
@@ -9,7 +9,8 @@ body:
description: What Apache Iceberg version are you using?
multiple: false
options:
- - "1.1.0 (latest release)"
Review Comment:
good point, I have a PR open for updating release process, looks like this and also REV API update needs to be added https://github.com/apache/iceberg-docs/pull/210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org