You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2018/10/24 09:14:48 UTC

[GitHub] brooklyn-ui pull request #90: DSL editor: allow ref to entity anywhere

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-ui/pull/90

    DSL editor: allow ref to entity anywhere

    This change means that the DSL editor will let you choose a reference to an entity in any config key (rather than only if the config key is of type `Entity`).
    
    This makes it more consistent with the rest of the DSL editor: e.g. if generating `attributeWhenReady`, it doesn't type-check the attributes' types to filter the view to only those that match the config key's type. This is a good thing, because otherwise we'd have to repeat all the type coercion rules in the UI, for it to know what is legal!
    
    ---
    I tested this by running `npm run start` in brooklyn-ui/ui-modules/blueprint-composer. I chose a couple of arbitrary entities, and successfully wired up a config key's value to reference the other entity:
    
    <img width="822" alt="dsl-editor-entity-ref" src="https://user-images.githubusercontent.com/593113/47419941-30857c00-d775-11e8-9509-2bc87a8fb146.png">


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-ui dsl-editor-allow-entity-ref

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-ui/pull/90.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #90
    
----
commit e8762af21c1567493d491a2e4a5ff26384026941
Author: Aled Sage <al...@...>
Date:   2018-10-24T09:09:18Z

    DSL editor: allow ref to entity anywhere

----


---

[GitHub] brooklyn-ui issue #90: DSL editor: allow ref to entity anywhere

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-ui/pull/90
  
    Ah, you beat me to it @tbouron (and I should have refreshed my browser page to see your comment!). The build worked after you requested the retest. My retest was unnecessary.


---

[GitHub] brooklyn-ui issue #90: DSL editor: allow ref to entity anywhere

Posted by tbouron <gi...@git.apache.org>.

Github user tbouron commented on the issue:

    https://github.com/apache/brooklyn-ui/pull/90
  
    retest this please
    
    (as been aborted because build time > 40min. I tweaked the config to allow for more time)


---

[GitHub] brooklyn-ui pull request #90: DSL editor: allow ref to entity anywhere

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-ui/pull/90


---

[GitHub] brooklyn-ui issue #90: DSL editor: allow ref to entity anywhere

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-ui/pull/90
  
    retest this please
    
    Failed with seemingly unrelated failure in a different module:
    ```
    [ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.3:npm (npm install) on project brooklyn-ui-location-manager: Failed to run task: 'npm install' failed. java.lang.InterruptedException -> [Help 1]
    ```


---