[GitHub] [pinot] heatclub commented on issue #9152: Improving server segment download code

["heatclub (via GitHub)" <gi...@apache.org>]

heatclub commented on issue #9152:
URL: https://github.com/apache/pinot/issues/9152#issuecomment-1427104646

   Hi @jasperjiaguo 
   Sorry I was inactive here owing to some personal commitments.
   
   I went through the code and have below findings:
   **Existing flow**
   `BaseTableDataManager.downloadSegment() -> downloadSegmentFromDeepStore() -> downloadAndDecrypt() -> downloadFromPeersWithoutStreaming calls these in SegmentFetcherFactory (fetchAndDecryptSegmentToLocal -> fetchAndDecryptSegmentToLocalInternal -> fetchSegmentToLocal -> fetchSegmentToLocalInternal -> fetchSegmentToLocal -> RetryPolicies.exponentialBackoffRetryPolicy with fetchSegmentToLocalWithoutRetry() -> BaseTableDataManager.untarAndMoveSegment()`
   
   **New proposed flow**
   `BaseTableDataManager.downloadSegment() -> downloadSegmentFromDeepStore() -> downloadAndDecrypt() -> { same function calls as above for  SegmentFetcherFactory } -> BaseTableDataManager.untarAndMoveSegmentWithRetries()`
   
   New function BaseTableDataManager.untarAndMoveSegmentWithRetries() retries the download in case of failure in untar process.
   Above proposal is based on the fact that we need to retry upon untar failures and not on download failures as all download failures are already retried in code.
   Please feel free to correct me of that's not the case


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org