You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/28 21:56:05 UTC
[GitHub] [airflow] bbovenzi opened a new pull request #22578: Update modal buttons for mapped task instances
bbovenzi opened a new pull request #22578:
URL: https://github.com/apache/airflow/pull/22578
Right now in graph view, a user can click on a mapped task and see a summary in a modal. But they cannot see an individual mapped task. This PR fixes that with:
- Adds a new "All Mapped Instances" button to the `/taskinstance/list`, but filtered to just that DAG run
- Adds a dropdown to select a mapped instance by `map_index` and update the modal
- Adds a back button to return the modal back to the task summary
<img width="607" alt="Screen Shot 2022-03-28 at 4 37 03 PM" src="https://user-images.githubusercontent.com/4600967/160493818-63463b14-e41b-41d7-a2a6-9dd628647a12.png">
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22578: Update modal buttons for mapped task instances
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22578:
URL: https://github.com/apache/airflow/pull/22578#issuecomment-1083190931
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a change in pull request #22578: Update modal buttons for mapped task instances
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on a change in pull request #22578:
URL: https://github.com/apache/airflow/pull/22578#discussion_r837624834
##########
File path: airflow/www/static/js/dag.js
##########
@@ -54,6 +54,9 @@ let executionDate = '';
let subdagId = '';
let dagRunId = '';
let mapIndex;
+let runId;
Review comment:
Yes, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #22578: Update modal buttons for mapped task instances
Posted by GitBox <gi...@apache.org>.
bbovenzi merged pull request #22578:
URL: https://github.com/apache/airflow/pull/22578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #22578: Update modal buttons for mapped task instances
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #22578:
URL: https://github.com/apache/airflow/pull/22578#discussion_r837005669
##########
File path: airflow/www/static/js/dag.js
##########
@@ -54,6 +54,9 @@ let executionDate = '';
let subdagId = '';
let dagRunId = '';
let mapIndex;
+let runId;
Review comment:
Does `dagRunId` not serve the same purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org