You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/18 02:17:03 UTC

[GitHub] [pulsar] Jason918 commented on a diff in pull request #15190: [improve][java-client] Better error message for `reconsumeLater`

Jason918 commented on code in PR #15190:
URL: https://github.com/apache/pulsar/pull/15190#discussion_r851840775


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java:
##########
@@ -466,7 +466,7 @@ public CompletableFuture<Void> reconsumeLaterAsync(Message<?> message, long dela
     public CompletableFuture<Void> reconsumeLaterAsync(
             Message<?> message, Map<String, String> customProperties, long delayTime, TimeUnit unit) {
         if (!conf.isRetryEnable()) {
-            return FutureUtil.failedFuture(new PulsarClientException("reconsumeLater method not support!"));
+            return FutureUtil.failedFuture(new PulsarClientException("reconsumeLater method not supported! Have you enabled retries in your consumer?"));

Review Comment:
   It's better to change `supported` to `enabled`. We can provide a direct guide message about how to enable this, like "Please enable retry in ConsumerBuilder"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org