[GitHub] [nifi] jfrazee commented on a change in pull request #4385: NIFI-7600 - Defining JMS attribute types breaks due to invalid charac…

[GitBox <gi...@apache.org>]

jfrazee commented on a change in pull request #4385:
URL: https://github.com/apache/nifi/pull/4385#discussion_r450432161



##########
File path: nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/JMSPublisher.java
##########
@@ -108,6 +108,13 @@ void setMessageHeaderAndProperties(final Session session, final Message message,
                         }
                     } else {
                         // not a special attribute handled above, so send it as a property using the specified property type
+                        String key=entry.getKey();
+                        if (key.endsWith(".type")){

Review comment:
       If we go broad and apply this to anything ending in '.type' I think it deserves a WARN.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org