You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Mukul Kumar Singh (Jira)" <ji...@apache.org> on 2020/04/16 06:25:00 UTC
[jira] [Resolved] (HDDS-2682) OM File create request does not check
for existing directory with the same name
[ https://issues.apache.org/jira/browse/HDDS-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mukul Kumar Singh resolved HDDS-2682.
-------------------------------------
Fix Version/s: 0.6.0
Resolution: Fixed
Thanks for the contribution [~rakeshr] for the contribution and [~adoroszlai] for the review. I have merged this change.
> OM File create request does not check for existing directory with the same name
> -------------------------------------------------------------------------------
>
> Key: HDDS-2682
> URL: https://issues.apache.org/jira/browse/HDDS-2682
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
> Reporter: Supratim Deka
> Assignee: Rakesh Radhakrishnan
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.6.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Assume the following sequence of operations/requests:
> Req 1. create file -> /d1/d2/d3/d4/k1 (d3 implicitly is a sub-directory inside /d1/d2)
> Req 2. create file -> /d1/d2/d3 (d3 as a file inside /d1/d2)
> When processing request 2, OMFileCreateRequest needs to check if 'd1/d2/d3' is the name of an existing file or an existing directory. In which case the request has to fail.
> Currently for request 2, OM will check explicitly if there is a key '/d1/d2/d3' in the key table.
> Also for non-recursive create requests, OM will check if parent directory /d1/d2 already exists. For this, the OM iterates the key table to check if 'd1/d2' occurs as a prefix of any key in the key table - checkKeysUnderPath()
> What is missing in current behaviour?
> For OM File create, the table iterator must also determine if '/d1/d2/d3' exists as a prefix for any key in the key table - not just '/d1/d2'.
> This fix is required for the correctness of OzoneFS namespace. There is a potential performance impact - which is outside the scope of this jira and will be addressed separately.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org