You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pekko.apache.org by se...@apache.org on 2023/01/05 03:21:40 UTC

[incubator-pekko-connectors-kafka] 04/04: cleanup

This is an automated email from the ASF dual-hosted git repository.

seanglover pushed a commit to branch seglo/artifact-id-rename2
in repository https://gitbox.apache.org/repos/asf/incubator-pekko-connectors-kafka.git

commit f8e8bd586472e567f5d887aed2e6ec59c80e30f2
Author: Sean Glover <se...@seanglover.com>
AuthorDate: Wed Jan 4 22:21:08 2023 -0500

    cleanup
---
 .github/workflows/link-validator.yml | 77 ++++++++++++++++++------------------
 .github/workflows/release.yml        | 37 ++++++++---------
 CONTRIBUTING.md                      |  2 +
 3 files changed, 60 insertions(+), 56 deletions(-)

diff --git a/.github/workflows/link-validator.yml b/.github/workflows/link-validator.yml
index 8303453b..ba6ec609 100644
--- a/.github/workflows/link-validator.yml
+++ b/.github/workflows/link-validator.yml
@@ -1,38 +1,39 @@
-name: Link Validator
-
-on:
-  pull_request:
-#  schedule:
-#    - cron:  '0 6 * * 1'
-
-jobs:
-  validate-links:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v2
-        with:
-          # See https://github.com/actions/checkout/issues/299#issuecomment-677674415
-          ref: ${{ github.event.pull_request.head.sha }}
-          fetch-depth: 100
-
-      # temporarily disable git tag fetch (it fails because there are no tags)
-      #- name: Fetch tags
-      #  run: git fetch --depth=100 origin +refs/tags/*:refs/tags/*
-
-      - name: Set up JDK 11
-        uses: olafurpg/setup-scala@v13
-        with:
-          java-version: adopt@1.11.0-9
-
-      - name: Cache Coursier cache
-        uses: coursier/cache-action@v6
-
-      - name: sbt site
-        run: sbt docs/makeSite
-
-      - name: Install Coursier command line tool
-        run: curl -fLo cs https://git.io/coursier-cli-linux && chmod +x cs && ./cs
-
-      - name: Run Link Validator
-        run: ./cs launch net.runne::site-link-validator:0.2.2 -- scripts/link-validator.conf
+# TODO: Fix after documentation updates
+#name: Link Validator
+#
+#on:
+#  pull_request:
+##  schedule:
+##    - cron:  '0 6 * * 1'
+#
+#jobs:
+#  validate-links:
+#    runs-on: ubuntu-latest
+#    steps:
+#      - name: Checkout
+#        uses: actions/checkout@v2
+#        with:
+#          # See https://github.com/actions/checkout/issues/299#issuecomment-677674415
+#          ref: ${{ github.event.pull_request.head.sha }}
+#          fetch-depth: 100
+#
+#      # temporarily disable git tag fetch (it fails because there are no tags)
+#      #- name: Fetch tags
+#      #  run: git fetch --depth=100 origin +refs/tags/*:refs/tags/*
+#
+#      - name: Set up JDK 11
+#        uses: olafurpg/setup-scala@v13
+#        with:
+#          java-version: adopt@1.11.0-9
+#
+#      - name: Cache Coursier cache
+#        uses: coursier/cache-action@v6
+#
+#      - name: sbt site
+#        run: sbt docs/makeSite
+#
+#      - name: Install Coursier command line tool
+#        run: curl -fLo cs https://git.io/coursier-cli-linux && chmod +x cs && ./cs
+#
+#      - name: Run Link Validator
+#        run: ./cs launch net.runne::site-link-validator:0.2.2 -- scripts/link-validator.conf
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 69ca683c..7a8becc7 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -13,7 +13,7 @@ on:
 jobs:
   release:
     # runs on main repo only
-    if: github.repository == 'akka/alpakka-kafka'
+    if: github.repository == 'apache/incubator-pekko-connectors-kafka'
     name: Release
     # the release environment provides access to secrets required in the release process
     # https://github.com/akka/alpakka-kafka/settings/environments/84275678/edit
@@ -40,20 +40,21 @@ jobs:
 
 #      - name: License checks
 
-      - name: Publish artifacts for all Scala versions
-        env:
-          PGP_PASSPHRASE: ${{ secrets.PGP_PASSPHRASE }}
-          PGP_SECRET: ${{ secrets.PGP_SECRET }}
-          SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }}
-          SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }}
-        run: sbt ci-release
-
-      - name: Publish API and reference documentation
-        env:
-          GUSTAV_KEY: ${{ secrets.GUSTAV_KEY }}
-        run: |+
-          eval "$(ssh-agent -s)"
-          echo $GUSTAV_KEY | base64 -di > .github/id_rsa
-          chmod 600 .github/id_rsa
-          ssh-add .github/id_rsa
-          sbt "++2.13.8 docs/publishRsync"
+# TODO: Separate snapshots and milestone releases (apache nightlies, sonatype)
+#      - name: Publish artifacts for all Scala versions
+#        env:
+#          PGP_PASSPHRASE: ${{ secrets.PGP_PASSPHRASE }}
+#          PGP_SECRET: ${{ secrets.PGP_SECRET }}
+#          SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }}
+#          SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }}
+#        run: sbt ci-release
+#
+#      - name: Publish API and reference documentation
+#        env:
+#          GUSTAV_KEY: ${{ secrets.GUSTAV_KEY }}
+#        run: |+
+#          eval "$(ssh-agent -s)"
+#          echo $GUSTAV_KEY | base64 -di > .github/id_rsa
+#          chmod 600 .github/id_rsa
+#          ssh-add .github/id_rsa
+#          sbt "++2.13.8 docs/publishRsync"
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 52967485..a2710124 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -37,6 +37,8 @@ For a Pull Request to be considered at all it has to meet these requirements:
 
 1. Regardless if the code introduces new features or fixes bugs or regressions, it must have comprehensive tests.
 
+1. The code must be well documented (see the [Documentation](#documentation) section below).
+
 1. The commit messages must properly describe the changes, see [further below](#creating-commits-and-writing-commit-messages).
 
 1. Do not use ``@author`` tags since it does not encourage [Collective Code Ownership](http://www.extremeprogramming.org/rules/collective.html). Contributors get the credit they deserve in the release notes.


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pekko.apache.org
For additional commands, e-mail: commits-help@pekko.apache.org