You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org> on 2012/02/28 03:07:49 UTC
[jira] [Commented] (ZOOKEEPER-1354)
AuthTest.testBadAuthThenSendOtherCommands fails intermittently
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217828#comment-13217828 ]
Hadoop QA commented on ZOOKEEPER-1354:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12516254/ZOOKEEPER-1354.patch
against trunk revision 1294000.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/965//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/965//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/965//console
This message is automatically generated.
> AuthTest.testBadAuthThenSendOtherCommands fails intermittently
> --------------------------------------------------------------
>
> Key: ZOOKEEPER-1354
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1354
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.4.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1354.patch
>
>
> I'm seeing the following intermittent failure:
> {noformat}
> junit.framework.AssertionFailedError: Should have called my watcher expected:<1> but was:<0>
> at org.apache.zookeeper.test.AuthTest.testBadAuthThenSendOtherCommands(AuthTest.java:89)
> at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> {noformat}
> The following commit introduced this test:
> bq. ZOOKEEPER-1152. Exceptions thrown from handleAuthentication can cause buffer corruption issues in NIOServer. (camille via breed)
> + Assert.assertEquals("Should have called my watcher",
> + 1, authFailed.get());
> I think it's due to either a) the code is not waiting for the
> notification to be propagated, or 2) the message doesn't make it back
> from the server to the client prior to the socket or the clientcnxn
> being closed.
> What do you think, should I just wait for the notification to arrive? or do you think it's 2). ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira