You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "dsoumis (via GitHub)" <gi...@apache.org> on 2024/06/05 08:21:33 UTC
[PR] Fix property ant.tstamp.now.iso ignored when building Tomcat JDBC poo… [tomcat]
dsoumis opened a new pull request, #733:
URL: https://github.com/apache/tomcat/pull/733
…l libraries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Fix property ant.tstamp.now.iso ignored when building Tomcat JDBC poo… [tomcat]
Posted by "dsoumis (via GitHub)" <gi...@apache.org>.
dsoumis commented on PR #733:
URL: https://github.com/apache/tomcat/pull/733#issuecomment-2160410399
> Is tstamp.iso.release defined at that spot @dsoumis ?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Fix property ant.tstamp.now.iso ignored when building Tomcat JDBC poo… [tomcat]
Posted by "isapir (via GitHub)" <gi...@apache.org>.
isapir commented on PR #733:
URL: https://github.com/apache/tomcat/pull/733#issuecomment-2150229542
Is `tstamp.iso.release` defined at that spot @dsoumis ? If so, maybe we can set a default for `ant.tstamp.now.iso` to be `tstamp.iso.release`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Fix property ant.tstamp.now.iso ignored when building Tomcat JDBC poo… [tomcat]
Posted by "ChristopherSchultz (via GitHub)" <gi...@apache.org>.
ChristopherSchultz commented on PR #733:
URL: https://github.com/apache/tomcat/pull/733#issuecomment-2161606328
> When running `ant deploy` to reproduce the build, `pre-release` target will not have been executed
If you are trying to reproduce the build, they you will have `build.properties.release` as generated by the release manager. That file contains (e.g.):
ant.tstamp.now.iso=2024-06-11T20:57:36Z
When running "deploy", I see this:
```
Setting project property: ant.tstamp.now.iso -> 2024-06-11T20:57:36Z
Setting project property: ant.tstamp.now.iso -> 2024-06-11T20:57:36Z
Override ignored for property "ant.tstamp.now.iso"
Setting project property: ant.tstamp.now.iso -> 2024-06-11T20:57:36Z
Override ignored for property "ant.tstamp.now.iso"
... [many times repeated]
```
However, when *not* using a source-release package:
```
$ ant -d deploy | grep ant.tstamp.now.iso
Property "ant.tstamp.now.iso" has not been set
Setting ro project property: ant.tstamp.now.iso -> ${ant.tstamp.now.iso}
[tstamp] magic property ant.tstamp.now.iso ignored as '${ant.tstamp.now.iso}' is not in valid ISO pattern
[tstamp] magic property ant.tstamp.now.iso ignored as '${ant.tstamp.now.iso}' is not in valid ISO pattern
```
> May not be an actual issue, but it disrupts the flawlessness of the process.
+1
The irony of the situation is that `ant.tstamp.now.iso` can be used to "set" the build timestamp for ant but ant does not set that property itself if it's not specified e.g. on the command-line. So it's basically never a good idea to use `${ant.tstamp.now.iso}` in your own build file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Fix property ant.tstamp.now.iso ignored when building Tomcat JDBC poo… [tomcat]
Posted by "ChristopherSchultz (via GitHub)" <gi...@apache.org>.
ChristopherSchultz merged PR #733:
URL: https://github.com/apache/tomcat/pull/733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Fix property ant.tstamp.now.iso ignored when building Tomcat JDBC poo… [tomcat]
Posted by "dsoumis (via GitHub)" <gi...@apache.org>.
dsoumis commented on PR #733:
URL: https://github.com/apache/tomcat/pull/733#issuecomment-2150200992
When running `ant deploy` to reproduce the build, `pre-release` target will not have been executed, ant.tstamp.now.iso has no value assigned and the following output is written:
> build-tomcat-jdbc:
[echo] Building Tomcat JDBC pool libraries
[tstamp] magic property ant.tstamp.now.iso ignored as '${ant.tstamp.now.iso}' is not in valid ISO pattern
[tstamp] magic property ant.tstamp.now.iso ignored as '${ant.tstamp.now.iso}' is not in valid ISO pattern
May not be an actual issue, but it disrupts the flawlessness of the process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org