You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/11 09:18:25 UTC

[GitHub] [pulsar] liangyepianzhou opened a new pull request #14238: [Transaction] Adopt single thread pool in TC

liangyepianzhou opened a new pull request #14238:
URL: https://github.com/apache/pulsar/pull/14238


   ### Motivation
   Optimize code and improve maintainability.
   ### Modification
   * Option 1 (the way I use)
   Create a thread pool at peer TC.
     * advantage
     Each TC has a single thread pool to perform its own tasks, and will not be blocked due to sharing a single  thread with other TCs
     * disadvantage
     Too many thread pools may be created
   * Option 2
   Create an ExecuteProvider in the TC service.  It create some single-threaded pools when the TC Service is created, and  then assign a single-threaded pool to TC when the TC is created
      * The advantages and disadvantages are opposite to the option one
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   Check the box below or label this PR directly (if you have committer privilege).
   
   Need to update docs? 
   
   - [ ] `doc-required` 
     
     (If you need help on updating docs, create a doc issue)
     
   - [x] `no-need-doc` 
     
     (Please explain why)
     
   - [ ] `doc` 
     
     (If this PR contains doc changes)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #14238: [Transaction] Adopt single thread pool in TC

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14238:
URL: https://github.com/apache/pulsar/pull/14238#issuecomment-1055903099


   This PR introduced a thread leak. Please review #14524 which is a fix for that particular problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] congbobo184 merged pull request #14238: [Transaction] Adopt single thread pool in TC

Posted by GitBox <gi...@apache.org>.
congbobo184 merged pull request #14238:
URL: https://github.com/apache/pulsar/pull/14238


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liangyepianzhou commented on pull request #14238: [Transaction] Adopt single thread pool in TC

Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on pull request #14238:
URL: https://github.com/apache/pulsar/pull/14238#issuecomment-1041043466


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org