[GitHub] [incubator-tvm] kazum commented on a change in pull request #5989: [BYOC][COREML] Handle one symbol for each runtime

[GitBox <gi...@apache.org>]

kazum commented on a change in pull request #5989:
URL: https://github.com/apache/incubator-tvm/pull/5989#discussion_r454246121



##########
File path: src/runtime/contrib/coreml/coreml_runtime.mm
##########
@@ -174,17 +158,17 @@
         CHECK(args[i].type_code() == kTVMDLTensorHandle || args[i].type_code() == kTVMNDArrayHandle)
             << "Expect NDArray or DLTensor as inputs\n";
         if (args[i].type_code() == kTVMDLTensorHandle) {
-          model.SetInput([input_names[i] UTF8String], args[i]);
+          model_->SetInput([input_names[i] UTF8String], args[i]);
         } else {
           LOG(FATAL) << "Not implemented";
         }
       }
 
       // Execute the subgraph.
-      model.Invoke();
+      model_->Invoke();
 
       // TODO: Support multiple outputs.
-      NDArray out = model.GetOutput(0);
+      NDArray out = model_->GetOutput(0);
       if (args[args.size() - 1].type_code() == kTVMDLTensorHandle) {
         DLTensor* arg = args[args.size() - 1];
         out.CopyTo(arg);

Review comment:
       Yes, will do it in the next PR :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org