You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Scott Tavares <st...@cox.net> on 2002/04/28 20:22:58 UTC
Tiny patch for Sybase EAServer
Sybase EAServer throws an exception if you try to put a null object into the
session. I'm not sure if the is correct behavior and at my best guess, it
probably is not, but this was easier to do then digging into all that.
Re: Tiny patch for Sybase EAServer
Posted by Daniel Rall <dl...@finemaltcoding.com>.
Oh. :-)
Anything under half a week or so is not late in my book.
"Scott Tavares" <st...@cox.net> writes:
> ...i meant that i was late with the "thanks for the link".
>
> ----- Original Message -----
> From: "Daniel Rall" <dl...@finemaltcoding.com>
> To: "Turbine Developers List" <tu...@jakarta.apache.org>
> Sent: Monday, June 03, 2002 7:25 PM
> Subject: Re: Tiny patch for Sybase EAServer
>
>
>> I've been on vacation in Europe, enjoying the blissful peace of
>> removal from all computers. I had to touch one once in an Internet
>> cafe to help my brother in law turn off win2k file sharing -- it was
>> traumatic.
>>
>> "Scott Tavares" <st...@cox.net> writes:
>>
>> > a little late but thanks for the link.
>> >
>> > -Scott-
>> >
>> > ----- Original Message -----
>> > From: "Daniel Rall" <dl...@collab.net>
>> > To: "Turbine Developers List" <tu...@jakarta.apache.org>
>> > Sent: Friday, May 31, 2002 2:31 PM
>> > Subject: Re: Tiny patch for Sybase EAServer
>> >
>> >
>> >> Hi Scott. Reading the servlet API documentation shows that passing
>> >> null as the second parameter of HttpSession::setAttribute() is a valid
>> >> operation, and should have the same affect as calling
>> >> removeAttribute():
>> >>
>> >>
>> >
> http://java.sun.com/products/servlet/2.3/javadoc/javax/servlet/http/HttpSess
> > > ion.html#setAttribute(java.lang.String,%20java.lang.Object)
>> > >
>> >> It's been the unwritten policy to not make changes to the repository
>> >> for bugs in specific vendor's software. As adding that null check
>> >> would actually change the fucntionality of the code below, this change
>> >> will not be incorporated. Please contact Sybase and have them fix the
>> >> bug in their app server.
>> >>
>> >> - Dan
>> >>
>> >>
>> >> "Scott Tavares" <st...@cox.net> writes:
>> >>
>> >> > Sybase EAServer throws an exception if you try to put a null object
> into
> > > the
>> > > > session. I'm not sure if the is correct behavior and at my best
> guess,
> > > it
>> > > > probably is not, but this was easier to do then digging into all
> that.
> > >> >
>> >> > Index:
>> > src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java
>> > > > ===================================================================
>> >> > RCS file:
>> >
> /home/cvspublic/jakarta-turbine-3/src/java/org/apache/turbine/services/runda
> > > ta/DefaultTurbineRunData.java,v
>> > > > retrieving revision 1.13
>> >> > diff -c -r1.13 DefaultTurbineRunData.java
>> >> > ***
>> > src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java
> 23
> > > Apr 2002 16:05:52 -0000 1.13
>> > > > ---
>> > src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java
> 28
> > > Apr 2002 18:10:39 -0000
>> > > > ***************
>> >> > *** 1085,1092 ****
>> >> > {
>> >> > session.setAttribute(
>> >> > User.SESSION_KEY, new SessionBindingEventProxy(user));
>> >> > ! session.setAttribute(
>> >> > ! AccessControlList.SESSION_KEY, (Object) acl);
>> >> > }
>> >> >
>> >> > /**
>> >> > --- 1085,1094 ----
>> >> > {
>> >> > session.setAttribute(
>> >> > User.SESSION_KEY, new SessionBindingEventProxy(user));
>> >> > !
>> >> > ! if(acl != null)
>> >> > ! session.setAttribute(
>> >> > ! AccessControlList.SESSION_KEY, (Object) acl);
>> >> > }
>> >> >
>> >> > /**
>> >>
>> >> --
>> >> To unsubscribe, e-mail:
>> > <ma...@jakarta.apache.org>
>> > > For additional commands, e-mail:
>> > <ma...@jakarta.apache.org>
>> > >
>> >>
>> >
>> >
>> > --
>> > To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> > > For additional commands, e-mail:
> <ma...@jakarta.apache.org>
> > >
>> >
>> > SPAM: ---- Start SpamAssassin results
>> > SPAM: 0 hits, 5 required;
>> > SPAM:
>> > SPAM: ---- End of SpamAssassin results
>>
>> --
>> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> > For additional commands, e-mail:
> <ma...@jakarta.apache.org>
> >
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
> SPAM: ---- Start SpamAssassin results
> SPAM: 0 hits, 5 required;
> SPAM:
> SPAM: ---- End of SpamAssassin results
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: Tiny patch for Sybase EAServer
Posted by Scott Tavares <st...@cox.net>.
...i meant that i was late with the "thanks for the link".
----- Original Message -----
From: "Daniel Rall" <dl...@finemaltcoding.com>
To: "Turbine Developers List" <tu...@jakarta.apache.org>
Sent: Monday, June 03, 2002 7:25 PM
Subject: Re: Tiny patch for Sybase EAServer
> I've been on vacation in Europe, enjoying the blissful peace of
> removal from all computers. I had to touch one once in an Internet
> cafe to help my brother in law turn off win2k file sharing -- it was
> traumatic.
>
> "Scott Tavares" <st...@cox.net> writes:
>
> > a little late but thanks for the link.
> >
> > -Scott-
> >
> > ----- Original Message -----
> > From: "Daniel Rall" <dl...@collab.net>
> > To: "Turbine Developers List" <tu...@jakarta.apache.org>
> > Sent: Friday, May 31, 2002 2:31 PM
> > Subject: Re: Tiny patch for Sybase EAServer
> >
> >
> >> Hi Scott. Reading the servlet API documentation shows that passing
> >> null as the second parameter of HttpSession::setAttribute() is a valid
> >> operation, and should have the same affect as calling
> >> removeAttribute():
> >>
> >>
> >
http://java.sun.com/products/servlet/2.3/javadoc/javax/servlet/http/HttpSess
> > ion.html#setAttribute(java.lang.String,%20java.lang.Object)
> > >
> >> It's been the unwritten policy to not make changes to the repository
> >> for bugs in specific vendor's software. As adding that null check
> >> would actually change the fucntionality of the code below, this change
> >> will not be incorporated. Please contact Sybase and have them fix the
> >> bug in their app server.
> >>
> >> - Dan
> >>
> >>
> >> "Scott Tavares" <st...@cox.net> writes:
> >>
> >> > Sybase EAServer throws an exception if you try to put a null object
into
> > the
> > > > session. I'm not sure if the is correct behavior and at my best
guess,
> > it
> > > > probably is not, but this was easier to do then digging into all
that.
> >> >
> >> > Index:
> > src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java
> > > > ===================================================================
> >> > RCS file:
> >
/home/cvspublic/jakarta-turbine-3/src/java/org/apache/turbine/services/runda
> > ta/DefaultTurbineRunData.java,v
> > > > retrieving revision 1.13
> >> > diff -c -r1.13 DefaultTurbineRunData.java
> >> > ***
> > src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java
23
> > Apr 2002 16:05:52 -0000 1.13
> > > > ---
> > src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java
28
> > Apr 2002 18:10:39 -0000
> > > > ***************
> >> > *** 1085,1092 ****
> >> > {
> >> > session.setAttribute(
> >> > User.SESSION_KEY, new SessionBindingEventProxy(user));
> >> > ! session.setAttribute(
> >> > ! AccessControlList.SESSION_KEY, (Object) acl);
> >> > }
> >> >
> >> > /**
> >> > --- 1085,1094 ----
> >> > {
> >> > session.setAttribute(
> >> > User.SESSION_KEY, new SessionBindingEventProxy(user));
> >> > !
> >> > ! if(acl != null)
> >> > ! session.setAttribute(
> >> > ! AccessControlList.SESSION_KEY, (Object) acl);
> >> > }
> >> >
> >> > /**
> >>
> >> --
> >> To unsubscribe, e-mail:
> > <ma...@jakarta.apache.org>
> > > For additional commands, e-mail:
> > <ma...@jakarta.apache.org>
> > >
> >>
> >
> >
> > --
> > To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> > For additional commands, e-mail:
<ma...@jakarta.apache.org>
> >
> >
> > SPAM: ---- Start SpamAssassin results
> > SPAM: 0 hits, 5 required;
> > SPAM:
> > SPAM: ---- End of SpamAssassin results
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: Tiny patch for Sybase EAServer
Posted by Daniel Rall <dl...@finemaltcoding.com>.
I've been on vacation in Europe, enjoying the blissful peace of
removal from all computers. I had to touch one once in an Internet
cafe to help my brother in law turn off win2k file sharing -- it was
traumatic.
"Scott Tavares" <st...@cox.net> writes:
> a little late but thanks for the link.
>
> -Scott-
>
> ----- Original Message -----
> From: "Daniel Rall" <dl...@collab.net>
> To: "Turbine Developers List" <tu...@jakarta.apache.org>
> Sent: Friday, May 31, 2002 2:31 PM
> Subject: Re: Tiny patch for Sybase EAServer
>
>
>> Hi Scott. Reading the servlet API documentation shows that passing
>> null as the second parameter of HttpSession::setAttribute() is a valid
>> operation, and should have the same affect as calling
>> removeAttribute():
>>
>>
> http://java.sun.com/products/servlet/2.3/javadoc/javax/servlet/http/HttpSess
> ion.html#setAttribute(java.lang.String,%20java.lang.Object)
> >
>> It's been the unwritten policy to not make changes to the repository
>> for bugs in specific vendor's software. As adding that null check
>> would actually change the fucntionality of the code below, this change
>> will not be incorporated. Please contact Sybase and have them fix the
>> bug in their app server.
>>
>> - Dan
>>
>>
>> "Scott Tavares" <st...@cox.net> writes:
>>
>> > Sybase EAServer throws an exception if you try to put a null object into
> the
> > > session. I'm not sure if the is correct behavior and at my best guess,
> it
> > > probably is not, but this was easier to do then digging into all that.
>> >
>> > Index:
> src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java
> > > ===================================================================
>> > RCS file:
> /home/cvspublic/jakarta-turbine-3/src/java/org/apache/turbine/services/runda
> ta/DefaultTurbineRunData.java,v
> > > retrieving revision 1.13
>> > diff -c -r1.13 DefaultTurbineRunData.java
>> > ***
> src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java 23
> Apr 2002 16:05:52 -0000 1.13
> > > ---
> src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java 28
> Apr 2002 18:10:39 -0000
> > > ***************
>> > *** 1085,1092 ****
>> > {
>> > session.setAttribute(
>> > User.SESSION_KEY, new SessionBindingEventProxy(user));
>> > ! session.setAttribute(
>> > ! AccessControlList.SESSION_KEY, (Object) acl);
>> > }
>> >
>> > /**
>> > --- 1085,1094 ----
>> > {
>> > session.setAttribute(
>> > User.SESSION_KEY, new SessionBindingEventProxy(user));
>> > !
>> > ! if(acl != null)
>> > ! session.setAttribute(
>> > ! AccessControlList.SESSION_KEY, (Object) acl);
>> > }
>> >
>> > /**
>>
>> --
>> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> > For additional commands, e-mail:
> <ma...@jakarta.apache.org>
> >
>>
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
> SPAM: ---- Start SpamAssassin results
> SPAM: 0 hits, 5 required;
> SPAM:
> SPAM: ---- End of SpamAssassin results
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: Tiny patch for Sybase EAServer
Posted by Scott Tavares <st...@cox.net>.
a little late but thanks for the link.
-Scott-
----- Original Message -----
From: "Daniel Rall" <dl...@collab.net>
To: "Turbine Developers List" <tu...@jakarta.apache.org>
Sent: Friday, May 31, 2002 2:31 PM
Subject: Re: Tiny patch for Sybase EAServer
> Hi Scott. Reading the servlet API documentation shows that passing
> null as the second parameter of HttpSession::setAttribute() is a valid
> operation, and should have the same affect as calling
> removeAttribute():
>
>
http://java.sun.com/products/servlet/2.3/javadoc/javax/servlet/http/HttpSess
ion.html#setAttribute(java.lang.String,%20java.lang.Object)
>
> It's been the unwritten policy to not make changes to the repository
> for bugs in specific vendor's software. As adding that null check
> would actually change the fucntionality of the code below, this change
> will not be incorporated. Please contact Sybase and have them fix the
> bug in their app server.
>
> - Dan
>
>
> "Scott Tavares" <st...@cox.net> writes:
>
> > Sybase EAServer throws an exception if you try to put a null object into
the
> > session. I'm not sure if the is correct behavior and at my best guess,
it
> > probably is not, but this was easier to do then digging into all that.
> >
> > Index:
src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java
> > ===================================================================
> > RCS file:
/home/cvspublic/jakarta-turbine-3/src/java/org/apache/turbine/services/runda
ta/DefaultTurbineRunData.java,v
> > retrieving revision 1.13
> > diff -c -r1.13 DefaultTurbineRunData.java
> > ***
src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java 23
Apr 2002 16:05:52 -0000 1.13
> > ---
src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java 28
Apr 2002 18:10:39 -0000
> > ***************
> > *** 1085,1092 ****
> > {
> > session.setAttribute(
> > User.SESSION_KEY, new SessionBindingEventProxy(user));
> > ! session.setAttribute(
> > ! AccessControlList.SESSION_KEY, (Object) acl);
> > }
> >
> > /**
> > --- 1085,1094 ----
> > {
> > session.setAttribute(
> > User.SESSION_KEY, new SessionBindingEventProxy(user));
> > !
> > ! if(acl != null)
> > ! session.setAttribute(
> > ! AccessControlList.SESSION_KEY, (Object) acl);
> > }
> >
> > /**
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: Tiny patch for Sybase EAServer
Posted by Daniel Rall <dl...@collab.net>.
Hi Scott. Reading the servlet API documentation shows that passing
null as the second parameter of HttpSession::setAttribute() is a valid
operation, and should have the same affect as calling
removeAttribute():
http://java.sun.com/products/servlet/2.3/javadoc/javax/servlet/http/HttpSession.html#setAttribute(java.lang.String,%20java.lang.Object)
It's been the unwritten policy to not make changes to the repository
for bugs in specific vendor's software. As adding that null check
would actually change the fucntionality of the code below, this change
will not be incorporated. Please contact Sybase and have them fix the
bug in their app server.
- Dan
"Scott Tavares" <st...@cox.net> writes:
> Sybase EAServer throws an exception if you try to put a null object into the
> session. I'm not sure if the is correct behavior and at my best guess, it
> probably is not, but this was easier to do then digging into all that.
>
> Index: src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java
> ===================================================================
> RCS file: /home/cvspublic/jakarta-turbine-3/src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java,v
> retrieving revision 1.13
> diff -c -r1.13 DefaultTurbineRunData.java
> *** src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java 23 Apr 2002 16:05:52 -0000 1.13
> --- src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java 28 Apr 2002 18:10:39 -0000
> ***************
> *** 1085,1092 ****
> {
> session.setAttribute(
> User.SESSION_KEY, new SessionBindingEventProxy(user));
> ! session.setAttribute(
> ! AccessControlList.SESSION_KEY, (Object) acl);
> }
>
> /**
> --- 1085,1094 ----
> {
> session.setAttribute(
> User.SESSION_KEY, new SessionBindingEventProxy(user));
> !
> ! if(acl != null)
> ! session.setAttribute(
> ! AccessControlList.SESSION_KEY, (Object) acl);
> }
>
> /**
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>