[GitHub] [dubbo-go-samples] cjphaha commented on a change in pull request #245: add jsonrpc tracing sample

[GitBox <gi...@apache.org>]

cjphaha commented on a change in pull request #245:
URL: https://github.com/apache/dubbo-go-samples/pull/245#discussion_r706855100



##########
File path: tracing/jsonrpc/go-server/conf/dubbogo.yml
##########
@@ -0,0 +1,23 @@
+# dubbo server yaml configure file
+
+dubbo:
+  registries:
+    "demoZK":
+      protocol: "zookeeper"

Review comment:
       这里的引号可以去掉，和其他的 sample 保持统一

##########
File path: tracing/jsonrpc/go-server/pkg/user.go
##########
@@ -15,8 +15,35 @@
  * limitations under the License.
  */
 
-package main
+package pkg
 
-var (
-	Version = "2.7.5"
+import (
+	"context"
+	gxlog "github.com/dubbogo/gost/log"

Review comment:
       这部分放在第二个 import 块

##########
File path: tracing/jsonrpc/go-server/docker/docker-compose.yml
##########
@@ -0,0 +1,42 @@
+version: '3'
+
+services:
+  zookeeper:
+    image: zookeeper
+    ports:
+      - 2181:2181
+    restart: on-failure
+
+  jaeger:
+    image: jaegertracing/all-in-one
+    ports:
+      - "6831:6831/udp"

Review comment:
       同上

##########
File path: tracing/jsonrpc/go-server/cmd/server.go
##########
@@ -19,89 +19,93 @@ package main
 
 import (
 	"fmt"
+
+	"github.com/opentracing/opentracing-go"
+	zipkinot "github.com/openzipkin-contrib/zipkin-go-opentracing"
+	"github.com/openzipkin/zipkin-go"
+	zipkinhttp "github.com/openzipkin/zipkin-go/reporter/http"

Review comment:
       这部分放在第二个 import 块比较好




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org