[GitHub] [incubator-druid] ijuma commented on a change in pull request #7466: Java 9 compatible ByteBuffer unmap operation

[GitBox <gi...@apache.org>]

ijuma commented on a change in pull request #7466: Java 9 compatible ByteBuffer unmap operation
URL: https://github.com/apache/incubator-druid/pull/7466#discussion_r275175832
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/utils/JvmUtils.java
 ##########
 @@ -23,9 +23,25 @@
 
 import java.lang.management.ManagementFactory;
 import java.lang.management.ThreadMXBean;
+import java.util.StringTokenizer;
 
 public class JvmUtils
 {
+  private static final boolean IS_JAVA9_COMPATIBLE = isJava9Compatible(System.getProperty("java.specification.version"));
 
 Review comment:
   Once Java 8 support is dropped, one can use https://docs.oracle.com/javase/9/docs/api/java/lang/Runtime.Version.html directly for version checks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org