You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Bruce Edge <br...@nextissuemedia.com> on 2014/11/07 04:50:49 UTC
Patch for quick & dirty debian package for sling launchpad
standalone.jar
I'm setting up a development env for a team to work on a sling asset manager app. I wanted to make the env setup simple so I put together a debian/ubuntu package for the org.apache.sling.launchpad-8-SNAPSHOT-standalone.jar.
It uses the jdeb maven plugin so it's cross-platform. Here's the patch on the off-chance it's compatible with the upstream policies. If it needs tuning, let me know what it's missing.
Not much mileage on it, but it installs, runs, etc.
-Bruce
Re: Patch for quick & dirty debian package for sling launchpad
standalone.jar
Posted by Bruce Edge <br...@nextissuemedia.com>.
Makes sense. I can do that. Will refactor into a new launchpad/builder dependent module.
-Bruce
From: Bertrand Delacretaz <bd...@apache.org>>
Reply-To: dev <de...@sling.apache.org>>
Date: Friday, November 7, 2014 at 12:47 AM
To: dev <de...@sling.apache.org>>
Subject: Re: Patch for quick & dirty debian package for sling launchpad standalone.jar
Hi,
On Fri, Nov 7, 2014 at 9:40 AM, Felix Meschberger <fm...@adobe.com>> wrote:
...Unfortunately the attachment didn't make it to the list...
I got Bruce's attachment in the moderation queue, copied it to
https://gist.github.com/bdelacretaz/03ece77da0a10741b8fb
I like the idea but would personally prefer having a separate
launchpad/debian module that creates the Debian package and depends on
the launchpad/builder module, instead of making the launchpad/builder
build more complex.
-Bertrand
Re: Patch for quick & dirty debian package for sling launchpad
standalone.jar
Posted by Bruce Edge <br...@nextissuemedia.com>.
inline
From: Bertrand Delacretaz <bd...@apache.org>>
Reply-To: dev <de...@sling.apache.org>>
Date: Monday, November 10, 2014 at 1:21 AM
To: dev <de...@sling.apache.org>>
Subject: Re: Patch for quick & dirty debian package for sling launchpad standalone.jar
Hi Bruce,
On Fri, Nov 7, 2014 at 7:08 PM, Bruce Edge
<br...@nextissuemedia.com>> wrote:
Updated patch here: https://gist.github.com/bedge/b07793932aeb8929d81f
Note, this is a peer module to builder rather than a submodule...
Makes sense, though my preference would be to have this in contrib
instead of the launchpad folder - what do others think?
I'm fine with that.
Also, I'll file a jira issue for tracking if that help make official. I just wanted to get a feel for the possibility of doing this before cluttering up the bug tracker with my wish list items.
Also, the patch has:
...Maintainer: Bruce Edge <br...@nextissuemedia.com>>...
Shall we put dev@sling.apache.org<ma...@sling.apache.org> here? Or will we get tons of
automated mail if we do so?
Good point.
Most debian packages use an email addr that's tied to the upstream distro, but still funnels down to the actual maintainer so that the redirect can be changed as packages are handed off to different maintainers.
Ideally something like a debian-maintainer@sling.apache.org that redirects to me for now, or, simply to the dev list. That way any influx of mail volume can be squashed by deleting the redirect.
-Bruce
(I've never created a Debian package myself, so mostly clueless)
-Bertrand
Re: Patch for quick & dirty debian package for sling launchpad
standalone.jar
Posted by Felix Meschberger <fm...@adobe.com>.
Hi
While the gist might be ok for review, I am concerned with the ingestion process: In any case I think we need a JIRA for committing such a change to our SVN. I would also prefer to have the patch attached to the issue to be able to track back what has been added.
Regards
Felix
> Am 10.11.2014 um 11:06 schrieb Bertrand Delacretaz <bd...@apache.org>:
>
> Hi,
>
> On Mon, Nov 10, 2014 at 11:04 AM, Robert Munteanu <ro...@apache.org> wrote:
>> ...is it enough for us to have received a link to
>> this gist via dev@sling or do we need a patch attached to Jira?...
>
> The gist is fine considering that Bruce has expressed his intention to
> contribute this code, earlier in this thread.
>
> -Bertrand
Re: Patch for quick & dirty debian package for sling launchpad standalone.jar
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,
On Mon, Nov 10, 2014 at 11:04 AM, Robert Munteanu <ro...@apache.org> wrote:
> ...is it enough for us to have received a link to
> this gist via dev@sling or do we need a patch attached to Jira?...
The gist is fine considering that Bruce has expressed his intention to
contribute this code, earlier in this thread.
-Bertrand
Re: Patch for quick & dirty debian package for sling launchpad standalone.jar
Posted by Robert Munteanu <ro...@apache.org>.
On Mon, Nov 10, 2014 at 11:21 AM, Bertrand Delacretaz
<bd...@apache.org> wrote:
> Hi Bruce,
>
> On Fri, Nov 7, 2014 at 7:08 PM, Bruce Edge
> <br...@nextissuemedia.com> wrote:
>> Updated patch here: https://gist.github.com/bedge/b07793932aeb8929d81f
>> Note, this is a peer module to builder rather than a submodule...
>
> Makes sense, though my preference would be to have this in contrib
> instead of the launchpad folder - what do others think?
contrib is fine for me.
On a different note, is it enough for us to have received a link to
this gist via dev@sling or do we need a patch attached to Jira?
Thanks,
Robert
>
> Also, the patch has:
>
> ...Maintainer: Bruce Edge <br...@nextissuemedia.com>...
>
> Shall we put dev@sling.apache.org here? Or will we get tons of
> automated mail if we do so?
>
> (I've never created a Debian package myself, so mostly clueless)
>
> -Bertrand
Re: Patch for quick & dirty debian package for sling launchpad
standalone.jar
Posted by Bruce Edge <br...@nextissuemedia.com>.
I've addressed all the issues raised so far.
JIRA with patch is here:
[ https://issues.apache.org/jira/browse/SLING-4151<https://issues.apache.org/jira/browse/SLING-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel> ]
-Bruce
From: Bertrand Delacretaz <bd...@apache.org>>
Reply-To: dev <de...@sling.apache.org>>
Date: Monday, November 10, 2014 at 1:21 AM
To: dev <de...@sling.apache.org>>
Subject: Re: Patch for quick & dirty debian package for sling launchpad standalone.jar
Hi Bruce,
On Fri, Nov 7, 2014 at 7:08 PM, Bruce Edge
<br...@nextissuemedia.com>> wrote:
Updated patch here: https://gist.github.com/bedge/b07793932aeb8929d81f
Note, this is a peer module to builder rather than a submodule...
Makes sense, though my preference would be to have this in contrib
instead of the launchpad folder - what do others think?
Also, the patch has:
...Maintainer: Bruce Edge <br...@nextissuemedia.com>>...
Shall we put dev@sling.apache.org<ma...@sling.apache.org> here? Or will we get tons of
automated mail if we do so?
(I've never created a Debian package myself, so mostly clueless)
-Bertrand
Re: Patch for quick & dirty debian package for sling launchpad standalone.jar
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi Bruce,
On Fri, Nov 7, 2014 at 7:08 PM, Bruce Edge
<br...@nextissuemedia.com> wrote:
> Updated patch here: https://gist.github.com/bedge/b07793932aeb8929d81f
> Note, this is a peer module to builder rather than a submodule...
Makes sense, though my preference would be to have this in contrib
instead of the launchpad folder - what do others think?
Also, the patch has:
...Maintainer: Bruce Edge <br...@nextissuemedia.com>...
Shall we put dev@sling.apache.org here? Or will we get tons of
automated mail if we do so?
(I've never created a Debian package myself, so mostly clueless)
-Bertrand
Re: Patch for quick & dirty debian package for sling launchpad
standalone.jar
Posted by Bruce Edge <br...@nextissuemedia.com>.
Updated patch here: https://gist.github.com/bedge/b07793932aeb8929d81f
Note, this is a peer module to builder rather than a submodule:
+++ b/pom.xml
...
<module>launchpad/builder</module>
+ <module>launchpad/debian</module>
as the latter would require altering the packaging type from war to pom
for the builder module.
-Bruce
From: Bertrand Delacretaz <bd...@apache.org>
Reply-To: dev <de...@sling.apache.org>
Date: Friday, November 7, 2014 at 12:47 AM
To: dev <de...@sling.apache.org>
Subject: Re: Patch for quick & dirty debian package for sling launchpad
standalone.jar
>Hi,
>
>On Fri, Nov 7, 2014 at 9:40 AM, Felix Meschberger <fm...@adobe.com>
>wrote:
>> ...Unfortunately the attachment didn¹t make it to the list...
>
>I got Bruce's attachment in the moderation queue, copied it to
>https://gist.github.com/bdelacretaz/03ece77da0a10741b8fb
>
>I like the idea but would personally prefer having a separate
>launchpad/debian module that creates the Debian package and depends on
>the launchpad/builder module, instead of making the launchpad/builder
>build more complex.
>
>-Bertrand
Re: Patch for quick & dirty debian package for sling launchpad standalone.jar
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,
On Fri, Nov 7, 2014 at 9:40 AM, Felix Meschberger <fm...@adobe.com> wrote:
> ...Unfortunately the attachment didn’t make it to the list...
I got Bruce's attachment in the moderation queue, copied it to
https://gist.github.com/bdelacretaz/03ece77da0a10741b8fb
I like the idea but would personally prefer having a separate
launchpad/debian module that creates the Debian package and depends on
the launchpad/builder module, instead of making the launchpad/builder
build more complex.
-Bertrand
Re: Patch for quick & dirty debian package for sling launchpad
standalone.jar
Posted by Felix Meschberger <fm...@adobe.com>.
Hi Bruce
This sounds like a very interesting stuff !
Unfortunately the attachment didn’t make it to the list. Do you mind creating a JIRA issue at https://issues.apache.org/jira/browse/SLING attaching the patch ? This would also allow us to properly track the „ingestion“.
Thank you very much.
Regards
Felix
Am 06.11.2014 um 19:50 schrieb Bruce Edge <br...@nextissuemedia.com>>:
I’m setting up a development env for a team to work on a sling asset manager app. I wanted to make the env setup simple so I put together a debian/ubuntu package for the org.apache.sling.launchpad-8-SNAPSHOT-standalone.jar.
It uses the jdeb maven plugin so it’s cross-platform. Here’s the patch on the off-chance it’s compatible with the upstream policies. If it needs tuning, let me know what it’s missing.
Not much mileage on it, but it installs, runs, etc.
-Bruce