You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2023/01/12 21:03:15 UTC
[GitHub] [maven-compiler-plugin] psiroky opened a new pull request, #167: [MCOMPILER-520] Upgrade parent to version 39 + reformat code
psiroky opened a new pull request, #167:
URL: https://github.com/apache/maven-compiler-plugin/pull/167
* I reformatted also the IT projects so that the code there is somewhat consistent with the main code base. That makes the PR i bit bigger, so I could possibly split that up if needed
Following this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCOMPILER) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] psiroky commented on a diff in pull request #167: [MCOMPILER-520] Upgrade parent to version 39 + reformat code
Posted by GitBox <gi...@apache.org>.
psiroky commented on code in PR #167:
URL: https://github.com/apache/maven-compiler-plugin/pull/167#discussion_r1068748398
##########
pom.xml:
##########
@@ -208,6 +193,19 @@ under the License.
</dependency>
</dependencies>
+ <repositories>
+ <repository>
+ <releases>
+ <enabled>false</enabled>
+ </releases>
+ <snapshots>
+ <enabled>true</enabled>
+ </snapshots>
+ <id>plexus.snapshots</id>
+ <url>https://oss.sonatype.org/content/repositories/plexus-snapshots</url>
+ </repository>
+ </repositories>
Review Comment:
I am wondering if this is correct? Should we have another repository directly hard-coded in the POM?
I know this has been used to get SNAPSHOTS in the past, but currently the plexus-compiler is a release version, and I assume it should stay that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] psiroky commented on pull request #167: [MCOMPILER-520] Upgrade parent to version 39 + reformat code
Posted by GitBox <gi...@apache.org>.
psiroky commented on PR #167:
URL: https://github.com/apache/maven-compiler-plugin/pull/167#issuecomment-1383227112
This actually does loads of changes and is likely impossible to reasonably review.
Probably better if one of the trusted core committers does the reformatting - at least for the production code, so the review would not really be needed.
I am keeping the branch around if anyone would like to reuse it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] psiroky closed pull request #167: [MCOMPILER-520] Upgrade parent to version 39 + reformat code
Posted by GitBox <gi...@apache.org>.
psiroky closed pull request #167: [MCOMPILER-520] Upgrade parent to version 39 + reformat code
URL: https://github.com/apache/maven-compiler-plugin/pull/167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] psiroky commented on a diff in pull request #167: [MCOMPILER-520] Upgrade parent to version 39 + reformat code
Posted by GitBox <gi...@apache.org>.
psiroky commented on code in PR #167:
URL: https://github.com/apache/maven-compiler-plugin/pull/167#discussion_r1068748398
##########
pom.xml:
##########
@@ -208,6 +193,19 @@ under the License.
</dependency>
</dependencies>
+ <repositories>
+ <repository>
+ <releases>
+ <enabled>false</enabled>
+ </releases>
+ <snapshots>
+ <enabled>true</enabled>
+ </snapshots>
+ <id>plexus.snapshots</id>
+ <url>https://oss.sonatype.org/content/repositories/plexus-snapshots</url>
+ </repository>
+ </repositories>
Review Comment:
I am wondering if this correct? Should we have another repository directly hardcoded in the POM?
I know this has been used to get SNAPSHOTS in the past, but currently the plexus-compiler is a release version, and I assume it should stay that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org