You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/06/23 20:20:55 UTC
[GitHub] [incubator-mxnet] josephevans opened a new pull request #20377: [v1.x] License updates per ASF feedback
josephevans opened a new pull request #20377:
URL: https://github.com/apache/incubator-mxnet/pull/20377
Address licensing concerns raised by our IPMC mentors:
1. Do not distribute 3rdparty/googletest/ci in source archive
2. Do not distribute docs/*** in source archive
3. Remove references to docs in LICENSE that are no longer distributed in source archive
4. Clarify include/mkldnn in LICENSE
5. Remove SIL open font license from licenses/ and reference in LICENSE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #20377: [v1.x] License updates per ASF feedback
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #20377:
URL: https://github.com/apache/incubator-mxnet/pull/20377#discussion_r657437029
##########
File path: tools/source-exclude-artifacts.txt
##########
@@ -22,3 +22,5 @@
R-package
3rdparty/mkldnn/doc
+3rdparty/googletest/ci
+docs
Review comment:
docs folder also contains the install instructions (build_from_source page)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #20377: [v1.x] License updates per ASF feedback
Posted by GitBox <gi...@apache.org>.
josephevans commented on a change in pull request #20377:
URL: https://github.com/apache/incubator-mxnet/pull/20377#discussion_r657521309
##########
File path: tools/source-exclude-artifacts.txt
##########
@@ -22,3 +22,5 @@
R-package
3rdparty/mkldnn/doc
+3rdparty/googletest/ci
+docs
Review comment:
True, but the git version tag will always be there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TristonC commented on a change in pull request #20377: [v1.x] License updates per ASF feedback
Posted by GitBox <gi...@apache.org>.
TristonC commented on a change in pull request #20377:
URL: https://github.com/apache/incubator-mxnet/pull/20377#discussion_r658166835
##########
File path: tools/source-exclude-artifacts.txt
##########
@@ -22,3 +22,5 @@
R-package
3rdparty/mkldnn/doc
+3rdparty/googletest/ci
+docs
Review comment:
@josephevans Can we only keep the install instructions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #20377: [v1.x] License updates per ASF feedback
Posted by GitBox <gi...@apache.org>.
josephevans commented on a change in pull request #20377:
URL: https://github.com/apache/incubator-mxnet/pull/20377#discussion_r657481078
##########
File path: tools/source-exclude-artifacts.txt
##########
@@ -22,3 +22,5 @@
R-package
3rdparty/mkldnn/doc
+3rdparty/googletest/ci
+docs
Review comment:
I would think most users building from source are following instructions from a web site, not viewing them from the source tree (after all, they are in .md format and would require viewing through a formatter/browser.) Do you think it's a requirement to ship them out in the source archive though?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #20377: [v1.x] License updates per ASF feedback
Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #20377:
URL: https://github.com/apache/incubator-mxnet/pull/20377#issuecomment-867195572
Removing entire docs directory just because of few fonts seems like quite a heavy handed approach. Could we instead just download those fonts as part of docs CD pipeline?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #20377: [v1.x] License updates per ASF feedback
Posted by GitBox <gi...@apache.org>.
josephevans commented on a change in pull request #20377:
URL: https://github.com/apache/incubator-mxnet/pull/20377#discussion_r658223312
##########
File path: tools/source-exclude-artifacts.txt
##########
@@ -22,3 +22,5 @@
R-package
3rdparty/mkldnn/doc
+3rdparty/googletest/ci
+docs
Review comment:
If you mean the build instructions, they are in https://github.com/apache/incubator-mxnet/blob/v1.x/docs/static_site/src/pages/get_started/build_from_source.md - we could copy this file to the root source archive. Alternatively, we could create a README.txt file with a link to the instructions on the web-site (but the latest version would have to be published.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TristonC commented on a change in pull request #20377: [v1.x] License updates per ASF feedback
Posted by GitBox <gi...@apache.org>.
TristonC commented on a change in pull request #20377:
URL: https://github.com/apache/incubator-mxnet/pull/20377#discussion_r658115420
##########
File path: tools/source-exclude-artifacts.txt
##########
@@ -22,3 +22,5 @@
R-package
3rdparty/mkldnn/doc
+3rdparty/googletest/ci
+docs
Review comment:
@josephevans Does doc cause the license issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] kezhenxu94 commented on a change in pull request #20377: [v1.x] License updates per ASF feedback
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #20377:
URL: https://github.com/apache/incubator-mxnet/pull/20377#discussion_r657820474
##########
File path: tools/source-exclude-artifacts.txt
##########
@@ -22,3 +22,5 @@
R-package
3rdparty/mkldnn/doc
+3rdparty/googletest/ci
+docs
Review comment:
I think at least a link to the install instructions is needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20377: [v1.x] License updates per ASF feedback
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20377:
URL: https://github.com/apache/incubator-mxnet/pull/20377#issuecomment-867131212
Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-cpu, windows-cpu, unix-cpu, website, clang, centos-gpu, sanity, edge, windows-gpu, miscellaneous, unix-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky merged pull request #20377: [v1.x] License updates per ASF feedback
Posted by GitBox <gi...@apache.org>.
samskalicky merged pull request #20377:
URL: https://github.com/apache/incubator-mxnet/pull/20377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TristonC commented on a change in pull request #20377: [v1.x] License updates per ASF feedback
Posted by GitBox <gi...@apache.org>.
TristonC commented on a change in pull request #20377:
URL: https://github.com/apache/incubator-mxnet/pull/20377#discussion_r658166085
##########
File path: tools/source-exclude-artifacts.txt
##########
@@ -22,3 +22,5 @@
R-package
3rdparty/mkldnn/doc
+3rdparty/googletest/ci
+docs
Review comment:
Have you or have you heard anyone use the docs inside the release package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #20377: [v1.x] License updates per ASF feedback
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #20377:
URL: https://github.com/apache/incubator-mxnet/pull/20377#discussion_r657496454
##########
File path: tools/source-exclude-artifacts.txt
##########
@@ -22,3 +22,5 @@
R-package
3rdparty/mkldnn/doc
+3rdparty/googletest/ci
+docs
Review comment:
I don't think it's a requirement, but it's not ideal as the website may change over time, while the archive remains fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] josephevans commented on pull request #20377: [v1.x] License updates per ASF feedback
Posted by GitBox <gi...@apache.org>.
josephevans commented on pull request #20377:
URL: https://github.com/apache/incubator-mxnet/pull/20377#issuecomment-867205725
> Removing entire docs directory just because of few fonts seems like quite a heavy handed approach. Could we instead just download those fonts as part of docs CD pipeline?
I agree that it's a fairly drastic change, but I am not convinced many users actually use the docs from the source archive. It takes a bit of effort to get them built and requires viewing them through a browser, and I would bet most people don't go through this effort and just use the documentation online.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org