You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by el...@apache.org on 2021/11/24 18:46:43 UTC
[superset] 09/14: fix: Header Actions test refactor (#16336)
This is an automated email from the ASF dual-hosted git repository.
elizabeth pushed a commit to branch refactorReports
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 7ee41178821faa3ea93ff97fa14387098b82ea73
Author: AAfghahi <48...@users.noreply.github.com>
AuthorDate: Thu Aug 19 13:23:42 2021 -0400
fix: Header Actions test refactor (#16336)
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <es...@gmail.com>
---
.../src/components/ReportModal/HeaderReportActionsDropdown/index.tsx | 4 ++--
superset-frontend/src/dashboard/components/Header/Header.test.tsx | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/superset-frontend/src/components/ReportModal/HeaderReportActionsDropdown/index.tsx b/superset-frontend/src/components/ReportModal/HeaderReportActionsDropdown/index.tsx
index f89eefb..2b5f891 100644
--- a/superset-frontend/src/components/ReportModal/HeaderReportActionsDropdown/index.tsx
+++ b/superset-frontend/src/components/ReportModal/HeaderReportActionsDropdown/index.tsx
@@ -49,8 +49,8 @@ export default function HeaderReportActionsDropDown({
any,
UserWithPermissionsAndRoles
>(state => state.user || state.explore?.user);
- const reportsIds = Object.keys(reports);
- const report: AlertObject = reports[reportsIds[0]];
+ const reportsIds = Object.keys(reports || []);
+ const report: AlertObject = reports?.[reportsIds[0]];
const [
currentReportDeleting,
setCurrentReportDeleting,
diff --git a/superset-frontend/src/dashboard/components/Header/Header.test.tsx b/superset-frontend/src/dashboard/components/Header/Header.test.tsx
index 29f2a7c..f27c318 100644
--- a/superset-frontend/src/dashboard/components/Header/Header.test.tsx
+++ b/superset-frontend/src/dashboard/components/Header/Header.test.tsx
@@ -57,6 +57,7 @@ const createProps = () => ({
dashboardTitle: 'Dashboard Title',
charts: {},
layout: {},
+ reports: {},
expandedSlices: {},
css: '',
customCss: '',