You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/06/08 18:14:52 UTC
[GitHub] [tinkerpop] L0Lmaker opened a new pull request, #1690: Gremlin Dotnet Windows Build fixes
L0Lmaker opened a new pull request, #1690:
URL: https://github.com/apache/tinkerpop/pull/1690
Link to Issue: [TINKERPOP-2749](https://issues.apache.org/jira/browse/TINKERPOP-2749)
This PR addresses Errors that cause the Windows build of Gremlin Dotnet to fail.
Issues Addressed:
1. Fixed an issue where groovy script defined in `gremlin-dotnet/src/pom.xml` receives an incorrectly formatted path for Windows. Single `\` characters are invalid in groovy and using `${project.basedir}` returns a string with non-escaped `\` characters in Windows.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #1690: Gremlin Dotnet Windows Build fixes
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1690:
URL: https://github.com/apache/tinkerpop/pull/1690#issuecomment-1150252326
# [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1690?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1690](https://codecov.io/gh/apache/tinkerpop/pull/1690?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f849d4) into [3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/ce9499467a8673724336364f2c78e6573e4baa5b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ce94994) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.5-dev #1690 +/- ##
===========================================
- Coverage 63.41% 63.35% -0.06%
===========================================
Files 23 23
Lines 3545 3553 +8
===========================================
+ Hits 2248 2251 +3
- Misses 1123 1129 +6
+ Partials 174 173 -1
```
| [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1690?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [gremlin-go/driver/resultSet.go](https://codecov.io/gh/apache/tinkerpop/pull/1690/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvcmVzdWx0U2V0Lmdv) | `80.18% <0.00%> (-7.45%)` | :arrow_down: |
| [gremlin-go/driver/connection.go](https://codecov.io/gh/apache/tinkerpop/pull/1690/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvY29ubmVjdGlvbi5nbw==) | `80.00% <0.00%> (-1.16%)` | :arrow_down: |
| [gremlin-go/driver/bytecode.go](https://codecov.io/gh/apache/tinkerpop/pull/1690/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvYnl0ZWNvZGUuZ28=) | `76.92% <0.00%> (ø)` | |
| [gremlin-go/driver/graphTraversal.go](https://codecov.io/gh/apache/tinkerpop/pull/1690/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvZ3JhcGhUcmF2ZXJzYWwuZ28=) | `89.11% <0.00%> (ø)` | |
| [gremlin-go/driver/protocol.go](https://codecov.io/gh/apache/tinkerpop/pull/1690/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvcHJvdG9jb2wuZ28=) | `63.20% <0.00%> (+0.99%)` | :arrow_up: |
| [gremlin-go/driver/client.go](https://codecov.io/gh/apache/tinkerpop/pull/1690/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvY2xpZW50Lmdv) | `82.41% <0.00%> (+3.29%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1690?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1690?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ce94994...1f849d4](https://codecov.io/gh/apache/tinkerpop/pull/1690?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] L0Lmaker commented on pull request #1690: TINKERPOP-2749: Gremlin Dotnet Windows Build fixes
Posted by GitBox <gi...@apache.org>.
L0Lmaker commented on PR #1690:
URL: https://github.com/apache/tinkerpop/pull/1690#issuecomment-1151660193
The .NET code builds successfully as well, but there is an issue where intermediate GitHub actions runs fail for the windows build (~1-2 out of 10). This issue needs to be more thoroughly investigated so for now I haven't added the Windows build in the GHA jobs. My apologies, I should've explained why I didn't add it in. I have updated the PR description to include this detail.
Ofcourse! I will create a follow-up issue detailing all the rest of the work for this issue in JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette closed pull request #1690: TINKERPOP-2749: Gremlin Dotnet Windows Build fixes
Posted by GitBox <gi...@apache.org>.
spmallette closed pull request #1690: TINKERPOP-2749: Gremlin Dotnet Windows Build fixes
URL: https://github.com/apache/tinkerpop/pull/1690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1690: Gremlin Dotnet Windows Build fixes
Posted by GitBox <gi...@apache.org>.
FlorianHockmann commented on PR #1690:
URL: https://github.com/apache/tinkerpop/pull/1690#issuecomment-1150809224
This is only about getting the Maven build to run without building the .NET code, i.e., without adding `-P gremlin-dotnet` which requires the .NET SDK to be installed, right? Just to be clear: It's ok in my opinion to first concentrate only on the maven build. I just wanted to ask so we're sure what's included here and what is not. It would be great in that case if you could create a follow-up issue in Jira where you note what's still TODO after TINKERPOP-2749 is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] L0Lmaker commented on pull request #1690: TINKERPOP-2749: Gremlin Dotnet Windows Build fixes
Posted by GitBox <gi...@apache.org>.
L0Lmaker commented on PR #1690:
URL: https://github.com/apache/tinkerpop/pull/1690#issuecomment-1160771672
Created a follow-up issue on JIRA.
Link to issue: [TINKERPOP-2760](https://issues.apache.org/jira/browse/TINKERPOP-2760)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] lyndonbauto commented on pull request #1690: TINKERPOP-2749: Gremlin Dotnet Windows Build fixes
Posted by GitBox <gi...@apache.org>.
lyndonbauto commented on PR #1690:
URL: https://github.com/apache/tinkerpop/pull/1690#issuecomment-1152662990
VOTE+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1690: TINKERPOP-2749: Gremlin Dotnet Windows Build fixes
Posted by GitBox <gi...@apache.org>.
FlorianHockmann commented on PR #1690:
URL: https://github.com/apache/tinkerpop/pull/1690#issuecomment-1152366327
Thanks for the explanation!
I also just tried it on my machine again and got it working, including the tests. The build somehow only converts some special characters sometimes, but I'm not sure what causes this and it might be specific to my machine. So we can ignore this for now from my side.
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1690: TINKERPOP-2749: Gremlin Dotnet Windows Build fixes
Posted by GitBox <gi...@apache.org>.
spmallette commented on PR #1690:
URL: https://github.com/apache/tinkerpop/pull/1690#issuecomment-1157084467
Cherry-picked as 4675011d960c60b499b1c6300591fdd2968ac8c6 to get rid of the merge commit. I had a conflict merging to 3.6-dev and wasn't sure how to proceed so I kept what was in 3.6-dev unchanged.
@L0Lmaker could you please have a look at how to port this change to 3.6-dev (if necessary) and issue another PR to that branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org