[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #1385: Remove generated alerts

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #1385:
URL: https://github.com/apache/iceberg/pull/1385#discussion_r477339694



##########
File path: flink/src/main/java/org/apache/iceberg/flink/RowDataTaskWriterFactory.java
##########
@@ -127,7 +126,7 @@ private FlinkFileAppenderFactory(Schema schema, RowType flinkSchema, Map<String,
     @Override
     public FileAppender<RowData> newAppender(OutputFile outputFile, FileFormat format) {
       // TODO MetricsConfig will be used for building parquet RowData writer.
-      MetricsConfig metricsConfig = MetricsConfig.fromProperties(props);
+      // MetricsConfig metricsConfig = MetricsConfig.fromProperties(props);

Review comment:
       My only question here is why not just delete the line and todo if we aren't using them and just have a github issue instead?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org