You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/08 15:45:08 UTC

[GitHub] [superset] kgabryje commented on a change in pull request #17037: chore(Dashboard): Disable save button in Native Filters when an error is present

kgabryje commented on a change in pull request #17037:
URL: https://github.com/apache/superset/pull/17037#discussion_r725121015



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/Footer/Footer.tsx
##########
@@ -60,6 +62,7 @@ const Footer: FC<FooterProps> = ({
         {t('Cancel')}
       </Button>
       <Button
+        disabled={canSave}

Review comment:
       Shouldn't that logic be the other way around? Like `disabled={!canSave}` or `disabled={cantSave}`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org