You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/01/24 23:14:38 UTC

[kudu-CR] env: properly use fdatasync on Linux 

Hello Dan Burkert,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/9128

to review the following change.


Change subject: env: properly use fdatasync on Linux
......................................................................

env: properly use fdatasync on Linux

A previous commit attempted to make env OSX-compatible by checking
whether fdatasync was defined and using fsync in the case that it was
not. However, that commit was buggy since it used #ifndef. fdatasync is
never a preprocessor macro, so it never was "defined" and we always
ended up using fsync regardless of the FLAGS_env_use_fsync value.

Change-Id: I366df37670ec241cbee6dcfe0efa56af7189e9a2
---
M src/kudu/util/env_posix.cc
1 file changed, 2 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/9128/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I366df37670ec241cbee6dcfe0efa56af7189e9a2
Gerrit-Change-Number: 9128
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>

[kudu-CR] env: properly use fdatasync on Linux

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9128

to look at the new patch set (#2).

Change subject: env: properly use fdatasync on Linux
......................................................................

env: properly use fdatasync on Linux

A previous commit attempted to make env OSX-compatible by checking
whether fdatasync was defined and using fsync in the case that it was
not. However, that commit was buggy since it used #ifndef. fdatasync is
never a preprocessor macro, so it never was "defined" and we always
ended up using fsync regardless of the FLAGS_env_use_fsync value.

Change-Id: I366df37670ec241cbee6dcfe0efa56af7189e9a2
---
M src/kudu/util/env_posix.cc
1 file changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/9128/2
-- 
To view, visit http://gerrit.cloudera.org:8080/9128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I366df37670ec241cbee6dcfe0efa56af7189e9a2
Gerrit-Change-Number: 9128
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] env: properly use fdatasync on Linux

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9128 )

Change subject: env: properly use fdatasync on Linux
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I366df37670ec241cbee6dcfe0efa56af7189e9a2
Gerrit-Change-Number: 9128
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Wed, 24 Jan 2018 23:26:11 +0000
Gerrit-HasComments: No

[kudu-CR] env: properly use fdatasync on Linux

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9128 )

Change subject: env: properly use fdatasync on Linux
......................................................................

env: properly use fdatasync on Linux

A previous commit attempted to make env OSX-compatible by checking
whether fdatasync was defined and using fsync in the case that it was
not. However, that commit was buggy since it used #ifndef. fdatasync is
never a preprocessor macro, so it never was "defined" and we always
ended up using fsync regardless of the FLAGS_env_use_fsync value.

Change-Id: I366df37670ec241cbee6dcfe0efa56af7189e9a2
Reviewed-on: http://gerrit.cloudera.org:8080/9128
Reviewed-by: Dan Burkert <da...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/util/env_posix.cc
1 file changed, 2 insertions(+), 6 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/9128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I366df37670ec241cbee6dcfe0efa56af7189e9a2
Gerrit-Change-Number: 9128
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>