You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2018/11/30 00:27:56 UTC

Review Request 69485: ATLAS-2984: updated export to include type definitions of relationships referenced by entities

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69485/
-----------------------------------------------------------

Review request for atlas, Abhishek Kadam, Ashutosh Mestry, keval bhatt, Kapildeo Nayak, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-2984
    https://issues.apache.org/jira/browse/ATLAS-2984


Repository: atlas


Description
-------

updated export module to include relationship-type definitions as well in atlas-typesdef.json file


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 3558d2a78 
  repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java 6b5db613c 
  repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java ab66460f6 


Diff: https://reviews.apache.org/r/69485/diff/1/


Testing
-------

- verified that atlas-typesdef.json in the exported zip file includes relationship-type definitions as well
- verified that importing the file creates relationship-types, if necessary
- pre-commit test run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/851/


Thanks,

Madhan Neethiraj


Re: Review Request 69485: ATLAS-2984: updated export to include type definitions of relationships referenced by entities

Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69485/#review210966
-----------------------------------------------------------


Ship it!




Ship It!

- Ashutosh Mestry


On Nov. 30, 2018, 12:27 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69485/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2018, 12:27 a.m.)
> 
> 
> Review request for atlas, Abhishek Kadam, Ashutosh Mestry, keval bhatt, Kapildeo Nayak, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2984
>     https://issues.apache.org/jira/browse/ATLAS-2984
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> updated export module to include relationship-type definitions as well in atlas-typesdef.json file
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 3558d2a78 
>   repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java 6b5db613c 
>   repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java ab66460f6 
> 
> 
> Diff: https://reviews.apache.org/r/69485/diff/1/
> 
> 
> Testing
> -------
> 
> - verified that atlas-typesdef.json in the exported zip file includes relationship-type definitions as well
> - verified that importing the file creates relationship-types, if necessary
> - pre-commit test run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/853/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>