You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mimaison (via GitHub)" <gi...@apache.org> on 2023/01/27 17:23:04 UTC
[GitHub] [kafka] mimaison opened a new pull request, #13170: MINOR: Remove unused methods in CoreUtils
mimaison opened a new pull request, #13170:
URL: https://github.com/apache/kafka/pull/13170
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on a diff in pull request #13170: MINOR: Remove unused methods in CoreUtils
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on code in PR #13170:
URL: https://github.com/apache/kafka/pull/13170#discussion_r1190178039
##########
core/src/test/scala/unit/kafka/utils/CoreUtilsTest.scala:
##########
@@ -223,7 +204,7 @@ class CoreUtilsTest extends Logging {
val map = new ConcurrentHashMap[Int, AtomicInteger]().asScala
implicit val executionContext = ExecutionContext.fromExecutorService(Executors.newFixedThreadPool(nThreads))
Review Comment:
As you are cleaning up some minor problems, feel free to type this `implicit val` as this is the recommended way:
```suggestion
implicit val executionContext: ExecutionContext = ExecutionContext.fromExecutorService(Executors.newFixedThreadPool(nThreads))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #13170: MINOR: Remove unused methods in CoreUtils
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13170:
URL: https://github.com/apache/kafka/pull/13170#issuecomment-1446015320
@tombentley can you take a look? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on a diff in pull request #13170: MINOR: Remove unused methods in CoreUtils
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on code in PR #13170:
URL: https://github.com/apache/kafka/pull/13170#discussion_r1190857226
##########
core/src/test/scala/unit/kafka/utils/CoreUtilsTest.scala:
##########
@@ -223,7 +204,7 @@ class CoreUtilsTest extends Logging {
val map = new ConcurrentHashMap[Int, AtomicInteger]().asScala
implicit val executionContext = ExecutionContext.fromExecutorService(Executors.newFixedThreadPool(nThreads))
Review Comment:
Looks good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison merged pull request #13170: MINOR: Remove unused methods in CoreUtils
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison merged PR #13170:
URL: https://github.com/apache/kafka/pull/13170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on a diff in pull request #13170: MINOR: Remove unused methods in CoreUtils
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on code in PR #13170:
URL: https://github.com/apache/kafka/pull/13170#discussion_r1190855504
##########
core/src/test/scala/unit/kafka/utils/CoreUtilsTest.scala:
##########
@@ -223,7 +204,7 @@ class CoreUtilsTest extends Logging {
val map = new ConcurrentHashMap[Int, AtomicInteger]().asScala
implicit val executionContext = ExecutionContext.fromExecutorService(Executors.newFixedThreadPool(nThreads))
Review Comment:
I've add to use `ExecutionContextExecutorService` instead of `ExecutionContext` because we call `shutdownNow()` below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org