You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/06 22:39:41 UTC

[GitHub] [incubator-mxnet] access2rohit opened a new pull request #19303: [FEATURE] Enable large tensor support for array_split

access2rohit opened a new pull request #19303:
URL: https://github.com/apache/incubator-mxnet/pull/19303


   ## Description ##
   LTS for numpy operator `array_split`
   
   ## Checklist ##
   ### Essentials ###
   - [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage
   - [x] Code is well-documented
   
   ### Testing ###
   ```
   (pytest) ubuntu@ip-172-31-90-243 ~/workspace/incubator-mxnet (array_split_lt) $ python -m pytest -s --exitfirst --verbose tests/nightly/test_np_large_array.py::test_array_split
   ==================================================================================================================================== test session starts ====================================================================================================================================
   platform linux -- Python 3.6.10, pytest-5.3.5, py-1.8.2, pluggy-0.13.1 -- /home/ubuntu/anaconda3/envs/pytest/bin/python
   cachedir: .pytest_cache
   rootdir: /home/ubuntu/workspace/incubator-mxnet, inifile: pytest.ini
   plugins: timeout-1.4.2
   timeout: 1200.0s
   timeout method: signal
   timeout func_only: False
   collected 1 item
   
   tests/nightly/test_np_large_array.py::test_array_split [22:37:13] ../src/storage/storage.cc:199: Using Pooled (Naive) StorageManager for CPU
   PASSED
   
   ===================================================================================================================================== warnings summary ======================================================================================================================================
   tests/nightly/test_np_large_array.py:92
     /home/ubuntu/workspace/incubator-mxnet/tests/nightly/test_np_large_array.py:92: DeprecationWarning: invalid escape sequence \
       '''
   
   tests/nightly/test_np_large_array.py:721
     /home/ubuntu/workspace/incubator-mxnet/tests/nightly/test_np_large_array.py:721: DeprecationWarning: invalid escape sequence \
       '''
   
   -- Docs: https://docs.pytest.org/en/latest/warnings.html
   =============================================================================================================================== 1 passed, 2 warnings in 7.92s ===============================================================================================================================
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] access2rohit commented on pull request #19303: [FEATURE] Enable large tensor support for array_split

Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19303:
URL: https://github.com/apache/incubator-mxnet/pull/19303#issuecomment-705763247


   @samskalicky / @mseth10 can you guys review and merge ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19303: [FEATURE] Enable large tensor support for array_split

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #19303:
URL: https://github.com/apache/incubator-mxnet/pull/19303#discussion_r500637837



##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -1324,3 +1324,15 @@ def test_cumsum():
     assert input.grad.shape == input.shape
     assert input.grad[0, 0] == INT_OVERFLOW
     assert input.grad[-1, -1] == 1
+
+
+@use_np
+def test_array_split():
+    A = np.ones((INT_OVERFLOW, 2))
+    A[0][0] = 0
+    A[-1][-1] = 2
+    B = np.array_split(A, 2)
+    assert B[0].shape ==(HALF_INT_OVERFLOW, 2)
+    assert B[1].shape ==(HALF_INT_OVERFLOW, 2)
+    assert B[0][0][0] == 0
+    assert B[1][-1][-1] == 2

Review comment:
       can you tweak the naming here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mseth10 commented on pull request #19303: [FEATURE] Enable large tensor support for array_split

Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #19303:
URL: https://github.com/apache/incubator-mxnet/pull/19303#issuecomment-705766992


   @access2rohit can you resolve conflicts?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mseth10 commented on pull request #19303: [FEATURE] Enable large tensor support for array_split

Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #19303:
URL: https://github.com/apache/incubator-mxnet/pull/19303#issuecomment-705766992


   @access2rohit can you resolve conflicts?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mseth10 merged pull request #19303: [FEATURE] Enable large tensor support for array_split

Posted by GitBox <gi...@apache.org>.
mseth10 merged pull request #19303:
URL: https://github.com/apache/incubator-mxnet/pull/19303


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19303: [FEATURE] Enable large tensor support for array_split

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19303:
URL: https://github.com/apache/incubator-mxnet/pull/19303#issuecomment-704590393


   Hey @access2rohit , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [miscellaneous, unix-gpu, centos-cpu, edge, centos-gpu, website, clang, windows-gpu, unix-cpu, sanity, windows-cpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] access2rohit commented on pull request #19303: [FEATURE] Enable large tensor support for array_split

Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19303:
URL: https://github.com/apache/incubator-mxnet/pull/19303#issuecomment-705763247


   @samskalicky / @mseth10 can you guys review and merge ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org