You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Miguel Ferreira <mi...@me.com> on 2014/07/23 13:40:26 UTC

Review Request 23843: Removed duplicated code block

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23843/
-----------------------------------------------------------

Review request for cloudstack, daan Hoogland, sanjeev n, and Hugo Trippaers.


Repository: cloudstack-git


Description
-------

Removed duplicated code block in method to create service offering.
The clone was setting storage type just a few lines bellow another code block that does the same.


Diffs
-----

  tools/marvin/marvin/lib/base.py 8d40591 

Diff: https://reviews.apache.org/r/23843/diff/


Testing
-------

Tests I'm running that create service offerings produce the same results before and after the change.


Thanks,

Miguel Ferreira

Re: Review Request 23843: Removed duplicated code block

Posted by daan Hoogland <da...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23843/#review48715
-----------------------------------------------------------

Ship it!


ad640e2fda383dde56fbb02504678e5971e2a2b9

- daan Hoogland


On July 23, 2014, 11:40 a.m., Miguel Ferreira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23843/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 11:40 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland, sanjeev n, and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Removed duplicated code block in method to create service offering.
> The clone was setting storage type just a few lines bellow another code block that does the same.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/lib/base.py 8d40591 
> 
> Diff: https://reviews.apache.org/r/23843/diff/
> 
> 
> Testing
> -------
> 
> Tests I'm running that create service offerings produce the same results before and after the change.
> 
> 
> Thanks,
> 
> Miguel Ferreira
> 
>