[GitHub] [arrow-rs] alamb commented on a diff in pull request #2386: Decouple parquet fuzz tests from converter (#1661)

[GitBox <gi...@apache.org>]

alamb commented on code in PR #2386:
URL: https://github.com/apache/arrow-rs/pull/2386#discussion_r943405047


##########
parquet/src/arrow/arrow_reader.rs:
##########
@@ -561,33 +560,23 @@ mod tests {
     #[test]
     fn test_fixed_length_binary_column_reader() {
         let converter = FixedSizeArrayConverter::new(20);
-        run_single_column_reader_tests::<
-            FixedLenByteArrayType,
-            FixedSizeBinaryArray,
-            FixedSizeArrayConverter,
-            RandFixedLenGen,
-        >(
+        run_single_column_reader_tests::<FixedLenByteArrayType, _, RandFixedLenGen>(

Review Comment:
   It took me a while to grok this, so I figured I would note it for any other reviewers:
   
   The reduction of generic arguments isn't a change in coverage (the same types are still covered) it is simply fewer generics required to express the same test (in this case on `FixedLenByteArrayType` 👍 )



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org