You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by Justin Mclean <ju...@classsoftware.com> on 2019/08/04 01:44:42 UTC

Re: [VOTE] RocketMQ-client-cpp 1.2.0 Release And Graduation

Hi,

I not entirely sure what release artefact you are voting on here. I would seperate the two votes and do a proper vote of the release artefact.

Remember release artefact must be signed and have hashes and must follow ASF policy when including 3rd party code, I can see 3rd party code in the repo but nothing in mentioned in LICENSE. I can also see 3rd party file that incorrectly have ASF headers on them. e.g [1]. Am I mistaken here?  If not I not would be -1 on having this release as an offical Apache release.

Thanks,
Justin

1. ./src/thread/disruptor/wait_strategy.h

Re: [VOTE] RocketMQ-client-cpp 1.2.0 Release And Graduation

Posted by Justin Mclean <ju...@classsoftware.com>.

Hi,

Sorry I didn’t notice how old this thread was but looking though other VOTE threads there seems to be some common issues. I’m send an email to teh PMC about it.

Thanks,
Justin