You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/16 13:26:33 UTC

[GitHub] [arrow-datafusion] xudong963 opened a new pull request #1457: try to use sqllogictest

xudong963 opened a new pull request #1457:
URL: https://github.com/apache/arrow-datafusion/pull/1457


   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #1453 
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #1457: try to use sqllogictest

Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #1457:
URL: https://github.com/apache/arrow-datafusion/pull/1457#discussion_r772041178



##########
File path: datafusion/Cargo.toml
##########
@@ -77,6 +77,7 @@ rand = "0.8"
 avro-rs = { version = "0.13", features = ["snappy"], optional = true }
 num-traits = { version = "0.2", optional = true }
 pyo3 = { version = "0.14", optional = true }
+sqllogictest = "0.1.0"

Review comment:
       i think this should go into dev-dependencies instead?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] xudong963 commented on pull request #1457: try to use sqllogictest

Posted by GitBox <gi...@apache.org>.
xudong963 commented on pull request #1457:
URL: https://github.com/apache/arrow-datafusion/pull/1457#issuecomment-1013696074


   Close the ticket for a moment.
   
   My final thought is to create an independent repo that runs independently to find bugs. If there is a bug, it'll automatically open an issue to datafusion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1457: try to use sqllogictest

Posted by GitBox <gi...@apache.org>.
xudong963 commented on a change in pull request #1457:
URL: https://github.com/apache/arrow-datafusion/pull/1457#discussion_r785315493



##########
File path: datafusion/Cargo.toml
##########
@@ -77,6 +77,7 @@ rand = "0.8"
 avro-rs = { version = "0.13", features = ["snappy"], optional = true }
 num-traits = { version = "0.2", optional = true }
 pyo3 = { version = "0.14", optional = true }
+sqllogictest = "0.1.0"

Review comment:
       yep




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] xudong963 closed pull request #1457: try to use sqllogictest

Posted by GitBox <gi...@apache.org>.
xudong963 closed pull request #1457:
URL: https://github.com/apache/arrow-datafusion/pull/1457


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org