You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucy.apache.org by Marvin Humphrey <ma...@rectangular.com> on 2011/05/30 17:59:04 UTC
[lucy-dev] "one down"
On Sun, May 29, 2011 at 06:16:33AM -0000, joes@apache.org wrote:
> Log:
> one down
> - * Tests for charmonizer need to become independent executables.
Nice work, Joe!
The new design is conceptually much more sensible in comparison to the
previous scheme of compiling Charmonizer's tests into the main Lucy XS shared
object and invoking them via an XS handle buried in
trunk/perl/lib/Lucy/Test.pm.
...
I'd also like to mark "one down" regarding Lucy's incubation progress.
Both Peter and Joe have now done significant hacking on the the Charmonizer
code base, and Nate helped with the high level design of Charmonizer,
including the QUOTE macro and the file layout. There are still files that
only I have touched and there is still knowledge to be dispersed regarding the
materials in charmonizer/src/Charmonizer/Core, but I think it's fair to say
that with regards to maintaining and improving Lucy's Charmonizer layer, there
is no longer any one committer who is indispensible.
Marvin Humphrey
Re: [lucy-dev] "one down"
Posted by Peter Karman <pe...@peknet.com>.
Marvin Humphrey wrote on 5/30/11 10:59 AM:
>
> I'd also like to mark "one down" regarding Lucy's incubation progress.
>
> Both Peter and Joe have now done significant hacking on the the Charmonizer
> code base, and Nate helped with the high level design of Charmonizer,
> including the QUOTE macro and the file layout. There are still files that
> only I have touched and there is still knowledge to be dispersed regarding the
> materials in charmonizer/src/Charmonizer/Core, but I think it's fair to say
> that with regards to maintaining and improving Lucy's Charmonizer layer, there
> is no longer any one committer who is indispensible.
+1 to spreading the charmonizer love around.
--
Peter Karman . http://peknet.com/ . peter@peknet.com
Re: [lucy-dev] "one down"
Posted by Marvin Humphrey <ma...@rectangular.com>.
On Mon, May 30, 2011 at 09:49:06AM -0700, Joe Schaefer wrote:
> FWIW we no longer build AllTests.o. I'll let you decide whether or not to
> remove that code.
I've zapped 'em. The Charmonizer/AllTests.[ch] files are gone now. Hooray!
We actually had not been using the code in AllTests.c for a long time -- not
since the Charmonizer test suite had been converted over to generate TAP.
Marvin Humphrey
Re: [lucy-dev] "one down"
Posted by Joe Schaefer <jo...@yahoo.com>.
Thx Marvin. FWIW we no longer build AllTests.o. I'll
let you decide whether or not to remove that code.
----- Original Message ----
> From: Marvin Humphrey <ma...@rectangular.com>
> To: lucy-dev@incubator.apache.org
> Sent: Mon, May 30, 2011 11:59:04 AM
> Subject: [lucy-dev] "one down"
>
> On Sun, May 29, 2011 at 06:16:33AM -0000, joes@apache.org wrote:
> > Log:
> > one down
>
> > - * Tests for charmonizer need to become independent executables.
>
> Nice work, Joe!
>
> The new design is conceptually much more sensible in comparison to the
> previous scheme of compiling Charmonizer's tests into the main Lucy XS shared
> object and invoking them via an XS handle buried in
> trunk/perl/lib/Lucy/Test.pm.
>
> ...
>
> I'd also like to mark "one down" regarding Lucy's incubation progress.
>
> Both Peter and Joe have now done significant hacking on the the Charmonizer
> code base, and Nate helped with the high level design of Charmonizer,
> including the QUOTE macro and the file layout. There are still files that
> only I have touched and there is still knowledge to be dispersed regarding
>the
> materials in charmonizer/src/Charmonizer/Core, but I think it's fair to say
> that with regards to maintaining and improving Lucy's Charmonizer layer,
there
> is no longer any one committer who is indispensible.
>
> Marvin Humphrey
>
>